build(deps): bump github.com/mgechev/revive from 1.2.5 to 1.3.2 in /tools#1289
Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
Closed
build(deps): bump github.com/mgechev/revive from 1.2.5 to 1.3.2 in /tools#1289dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
- Coverage 98.09% 97.93% -0.16%
==========================================
Files 50 50
Lines 3249 3249
==========================================
- Hits 3187 3182 -5
- Misses 53 57 +4
- Partials 9 10 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
@dependabot rebase |
Bumps [github.com/mgechev/revive](https://github.com/mgechev/revive) from 1.2.5 to 1.3.2. - [Release notes](https://github.com/mgechev/revive/releases) - [Changelog](https://github.com/mgechev/revive/blob/master/.goreleaser.yml) - [Commits](mgechev/revive@v1.2.5...v1.3.2) --- updated-dependencies: - dependency-name: github.com/mgechev/revive dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
67b3199 to
371bb9f
Compare
abhinav
added a commit
that referenced
this pull request
Aug 18, 2023
Zap has been maintaining its own bespoke linter setup for a while and it's starting to show its age. For example, the upgrade in #1289 can't go through without either making a change which we disagree with, or configuring revive separately to ignore that linter check. This PR switches to using golangci-lint to run linters. staticcheck is included and enabled by default. For revive, this adds the relevant opt-outs with adequate justification. It also enables a couple govet linter checks that would otherwise be difficult to enable. The result also simplifies our Makefile greatly with the minor added complexity that it assumes golangci-lint is already installed. Another advantage of this setup is that lint runs in a separate parallel CI job while the tests are doing their thing.
Collaborator
|
@dependabot rebase |
Collaborator
|
(Superseded by #1323. dependabot will close.) |
Contributor
Author
|
Looks like github.com/mgechev/revive is no longer a dependency, so this is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/mgechev/revive from 1.2.5 to 1.3.2.
Release notes
Sourced from github.com/mgechev/revive's releases.
Commits
81d85b5fix #824 (#829)ed6d9ceFix prefix trimming in struct-tag (#827)6d5bc51Move away from deprecated ioutils (#825)b508fa8fix(deps): update module golang.org/x/tools to v0.9.1 (#811)cd336fcFix invalid toml in rule.add-constant example (#819)e20c778add nolint to default list of acceptable comments for comment-spacings (#822)022236ffix: error message typo in revivelib.New5558566Prevent empty-block when looping over call exprdc6909bfix tests not passing after the modif of the default rules list (#817)b03e54fempty-block: Fix false positive on select {} (#805)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)