record invocation arguments in generated code#31
Merged
sywhang merged 1 commit intouber-go:mainfrom Jul 13, 2023
Merged
Conversation
|
|
sywhang
reviewed
Jul 11, 2023
Comment on lines
291
to
+296
| g.p("") | ||
| g.p("// Generated by this command:") | ||
| g.p("// %v", strings.Join(os.Args, " ")) |
Contributor
There was a problem hiding this comment.
Let's make this part of the same comment block. Otherwise the new comment block becomes separated from the rest of the package level comment.
Suggested change
| g.p("") | |
| g.p("// Generated by this command:") | |
| g.p("// %v", strings.Join(os.Args, " ")) | |
| g.p("//") | |
| g.p("// Generated by this command:") | |
| g.p("// %v", strings.Join(os.Args, " ")) |
f7ed795 to
23e5425
Compare
23e5425 to
aa0d61f
Compare
ErfanMomeniii
pushed a commit
to ErfanMomeniii/mock
that referenced
this pull request
Jul 15, 2023
r-hang
pushed a commit
that referenced
this pull request
May 14, 2024
Fixes a regression introduced in #31 (before, mockgen always added an empty line between package comment and preceding comments). “Code generated by” block should not be a part of the package comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #554