Conversation
Use switch instead of nested if-elses to enhance readability.
r-hang
approved these changes
Nov 25, 2023
r-hang
left a comment
Contributor
There was a problem hiding this comment.
Logic looks good to me.
Given the amount of code added in the form of InterfaceFromGoTypesType do you think it makes sense to add some type of test that reads from a checked in archive?
JacobOaks
reviewed
Nov 27, 2023
abhinav
reviewed
Nov 29, 2023
Contributor
Author
Yes, that's a good suggestion. Will make that change. |
abhinav
approved these changes
Dec 6, 2023
moisesvega
approved these changes
Jan 9, 2024
This was referenced Jun 10, 2025
sywhang
added a commit
that referenced
this pull request
Jun 12, 2025
This adds support for a 3rd option for creating mocks after reflect and source-mode: the archive mode. Archive mode lets you load archive files to create mocks. This can come in handy for writing Bazel rules that produce intermediary archive files and automatically codegen mocks in Bazel environments. Rebased version of #125 --------- Co-authored-by: Zhongpeng Lin <zplin@uber.com> Co-authored-by: Sung Yoon Whang <sungyoonwhang@gmail.com> Co-authored-by: Sung Yoon Whang <sungyoon@uber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for a 3rd option for creating mocks after reflect and source-mode: the archive mode. Archive mode lets you load archive files to create mocks. This can come in handy for writing Bazel rules that produce intermediary archive files and automatically codegen mocks in Bazel environments.