Conversation
Users previously had to work around the limitation that a named import in a patch would transform an unnamed import to a named import. That is, ```diff @@ var foo, X identifier @@ -import foo "example.com/foo" +import foo "example.com/foo/v2" foo.X ``` Would transform unnamed imports in matched files to named imports: ```diff package thing -import "example.com/foo" +import foo "example.com/foo/v2" ``` This was undesirable. Teach the import matcher and replacer to recognize that the matched import is unnamed, and remember that for later, associating it with the metavariable name, not the import path. Associating it with the import path would make it impossible to rename import paths like the case above. The implementaton is a bit messy, but we basically have to differentiate between the package name of an import and the identifier we use to refer to types defined in that import. Resolves #2
shirchen
approved these changes
Jun 25, 2021
abhinav
added a commit
that referenced
this pull request
Jul 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users previously had to work around the limitation that a named import in a
patch would transform an unnamed import to a named import.
That is,
Would transform unnamed imports in matched files to named imports:
This was undesirable.
Teach the import matcher and replacer to recognize that the matched import
is unnamed, and remember that for later, associating it with the
metavariable name, not the import path. Associating it with the import path
would make it impossible to rename import paths like the case above.
The implementaton is a bit messy, but we basically have to differentiate
between the package name of an import and the identifier we use to refer to
types defined in that import.
Resolves #2