Fix isTraceStack on newer Go versions#68
Merged
sywhang merged 1 commit intouber-go:masterfrom Sep 27, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 93.27% 93.33% +0.05%
==========================================
Files 4 6 +2
Lines 119 120 +1
==========================================
+ Hits 111 112 +1
Misses 5 5
Partials 3 3
Continue to review full report at Codecov.
|
manjari25
approved these changes
Sep 27, 2021
sywhang
added a commit
that referenced
this pull request
Oct 4, 2021
Preparing for releasing v1.1.12 with fixes from #68.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #66 .
On newer Go versions (1.16 onwards), the top of trace stacks is no longer
runtime.goparkunlock. We had a logic that relied on this being the case, which made the tests to fail with-traceflag for newer Go versions. However, to maintain backwards compatibility, we shouldn't just remove this check.This separates out the
isTraceStackinto a separate file that gets conditionally compiled on different Go versions (tracestack_old.gofor Go 1.15 and before andtracestack_new.gofor Go 1.16 and newer) to address this issue.Internal Ref: GO-887.