Ignore testing.runFuzzing and testing.runFuzzTests#105
Merged
r-hang merged 1 commit intouber-go:masterfrom Jun 28, 2023
Merged
Conversation
When Fuzz testing, if the `-fuzz` flag is used then the fuzzing engine is used to generate test cases out of the seed corpus, this causes `testing.runFuzzTests` to be blocked until a failing input is found or there is a signal to stop generating. On the other hand `testing.runFuzzTests` is called even without the use of the `-fuzz` flag, executes the input testing with all the elements in the seed corpus and it's blocked until every test has run. On both cases, goleak detects them as leaking goroutines, but this are expected goroutines. Internal Ref: GO-2002 Fix uber-go#104
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 96.52% 96.58% +0.05%
==========================================
Files 5 5
Lines 230 234 +4
==========================================
+ Hits 222 226 +4
Misses 5 5
Partials 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sywhang
approved these changes
Jun 27, 2023
r-hang
approved these changes
Jun 28, 2023
Merged
mway
added a commit
that referenced
this pull request
Oct 24, 2023
### Fixed - Built-in ignores now match function names more accurately. They will no longer ignore stacks because of file names that look similar to function names. (#112) ### Added - Add an `IgnoreAnyFunction` option to ignore stack traces that have the provided function anywhere in the stack. (#113) - Ignore `testing.runFuzzing` and `testing.runFuzzTests` alongside other already-ignored test functions (`testing.RunTests`, etc). (#105) ### Changed - Miscellaneous CI-related fixes. (#103, #108, #114) --------- Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Fuzz testing, if the
-fuzzflag is used then the fuzzing engine is used to generate test cases out of the seed corpus, this causestesting.runFuzzTeststo be blocked until a failing input is found or there is a signal to stop generating.On the other hand
testing.runFuzzTestsis called even without the use of the-fuzzflag, executes the input testing with all the elements in the seed corpus and it's blocked until every test has run.On both cases, goleak detects them as leaking goroutines, but this are expected goroutines.
Internal Ref: GO-2002
Fix #104