jar-infer/nullaway-integration-test/build.gradle (1)

37-39: Prefer lazy, type-safe cross-project task wiring

Using a string task path works, but prefer a lazy reference to avoid accidental eager realization and catch renames at compile time.

-tasks.withType(Test).configureEach {
-    dependsOn(":jar-infer:test-java-lib-jarinfer:embedAstubxIntoJar")
-}
+tasks.withType(Test).configureEach {
+    dependsOn(project(":jar-infer:test-java-lib-jarinfer").tasks.named("embedAstubxIntoJar"))
+}

jar-infer/test-android-lib-jarinfer/build.gradle (1)

20-25: Consider bumping SDK levels used via deps.build to modern values.

This module still inherits compile/target SDK 30 from gradle/dependencies.gradle; AGP 8.7 supports API up to 35 and expects Build Tools 34.0.0. Suggest raising compile/target SDK to ≥34 to avoid tooling incompatibilities. (developer.android.com)

gradle/dependencies.gradle (3)

17-23: Avoid adding buildscript classpath from an applied script; prefer build-logic or a tiny local comparator.

Adding semver4j via buildscript in a shared Gradle script can hurt configuration cache and complicate classpath resolution. Either:

• move this to buildSrc/precompiled plugin, or
• replace with a small inlined comparator (split on dots, compare ints/prerelease), avoiding extra dependencies.

---

32-45: Harden epApiVersion parsing error path.

Wrap Semver parsing in try/catch and throw a clear IllegalArgumentException when the property isn’t valid semver (even in LOOSE mode), to improve DX.

-    def requested = parseSemver(epApiVersion)
+    def requested
+    try {
+        requested = parseSemver(epApiVersion)
+    } catch (Throwable t) {
+        throw new IllegalArgumentException("Invalid epApiVersion: '${epApiVersion}'. Expected a semantic version.", t)
+    }

---

99-105: Android SDK constants are outdated for AGP 8.7.

These drive compile/target/min across modules. Consider:

• compileSdkVersion: 34 or 35
• targetSdkVersion: 34 or 35
  Keep minSdk as-is if tests require. (developer.android.com)

jar-infer/test-java-lib-jarinfer/build.gradle (3)

57-59: Finalize/dependency wiring can be simplified.

With the Jar task including the file, you can drop finalizedBy chains and just dependOn generateJarInferAstubx inside jar.

-jar.finalizedBy generateJarInferAstubx
-generateJarInferAstubx.configure { finalizedBy embedAstubxIntoJar }
+// handled in jar {} above

---

67-67: Duplicate dependency on CLI assemble.

This duplicates the dependsOn already present in generateJarInferAstubx; safe to remove.

-jar.dependsOn ":jar-infer:jar-infer-cli:assemble"
+// redundant; removed

---

41-43: Hardcoded CLI JAR path may drift.

If the CLI jar name includes version/classifier, this path will break. Consider resolving the artifact from the CLI project’s configurations or expose a dedicated configuration/Outgoing artifact.

library-model/test-library-model-generator/build.gradle (1)

54-56: Finalize chain is OK; consider removing redundant jar.dependsOn at Line 64.

With the above dependsOn/finalizedBy wiring, the extra “jar.dependsOn ':library-model:library-model-generator-cli:assemble'” (Line 64) is redundant. Drop it to reduce configuration work.

library-model/library-model-generator-integration-test/build.gradle (1)

35-37: Good safeguard to ensure embedding runs before tests.

Depending on “:library-model:test-library-model-generator:embedLibModelsAstubxIntoJar” guarantees the JAR is updated pre-test. Optionally, depend on that project’s “jar” task and wire embedding via the Jar task (as suggested in the other file) to avoid cross-project Exec execution from tests.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

jar-infer/test-java-lib-jarinfer/build.gradle (2)

42-51: Use Java Toolchains for a cross-platform, reproducible launcher (Windows-safe).

System.getProperty("java.home")/bin/java can be brittle on Windows and divorces the build from toolchains. Prefer a JavaLauncher from JavaToolchainService and set executable/args.

-    doFirst {
-        // use the same java as Gradle itself
-        def javaBin = new File(System.getProperty("java.home"), "bin/java")
-
-        commandLine javaBin.absolutePath,
-                "-jar",
-                jarInferCliJar.get().asFile.absolutePath,
-                "-i", baseJarFile.get().asFile.absolutePath,
-                "-o", outputAstubxFile.get().asFile.absolutePath
-    }
+    doFirst {
+        def toolchains = project.extensions.getByType(org.gradle.jvm.toolchain.JavaToolchainService)
+        // Pick the version your CLI targets (17 is a common baseline)
+        def launcher = toolchains.launcherFor { languageVersion = JavaLanguageVersion.of(17) }.get()
+        executable = launcher.executablePath.asFile.absolutePath
+        args "-jar",
+             jarInferCliJar.get().asFile.absolutePath,
+             "-i", baseJarFile.get().asFile.absolutePath,
+             "-o", outputAstubxFile.get().asFile.absolutePath
+    }

---

62-64: Good: embed via Jar task instead of post-processing.

dependsOn + from(...)/into(...) is the right, cacheable approach; avoids “jar uf” mutations.

jar-infer/test-java-lib-jarinfer/build.gradle (2)

28-34: Avoid hard dependency on ShadowJar type to reduce classpath coupling.

Referencing com.github.jengelman...ShadowJar here can break if the plugin isn’t on this project’s script classpath. Use an untyped TaskProvider and cast at usage.

-def shadowJarTask = cliProj.tasks.named(
-        "shadowJar",
-        com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
-        )
-def jarInferCliJar = shadowJarTask.flatMap { it.archiveFile }
+def shadowJarTask = cliProj.tasks.named("shadowJar")
+def jarInferCliJar = shadowJarTask.flatMap { (it as org.gradle.api.tasks.bundling.AbstractArchiveTask).archiveFile }

---

57-59: Optional: remove volatile manifest fields to improve reproducibility.

Build-Jdk and Build-OS vary across machines and reduce artifact reproducibility. Consider dropping them or gating behind a flag.

         attributes(
-                'Created-By' : "Gradle ${gradle.gradleVersion}",
-                'Build-Jdk'  : "${System.properties['java.version']} (${System.properties['java.vendor']} ${System.properties['java.vm.version']})",
-                'Build-OS'   : "${System.properties['os.name']} ${System.properties['os.arch']} ${System.properties['os.version']}"
+                'Created-By' : "Gradle ${gradle.gradleVersion}"
         )

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.