inertia deploy [REMOTE] (up, down, status, reset) and authentication by bobheadxi · Pull Request #30 · ubclaunchpad/inertia

bobheadxi · 2017-12-26T09:40:07Z

⌛ Status: ready for review

🎟️ Ticket(s): Closes #27, closes #32, closes #33, closes #38

👷 Changes

inertia deploy [REMOTE] down:
- Checks if inertia is only active container, errors if it is
- Kills all other containers
inertia deploy [REMOTE] up:
- If no git repository on server, clone using the repo URL in the post request
- deploy() project
inertia deploy [REMOTE] status:
- Returns a list of active non-daemon containers
inertia deploy [REMOTE] reset:
- kills containers and deletes contents of project folder
authentication using github token (Chad/#38 authorization #39)
Push events to Daemon:
- If no git repository on server, clone using the repo URL in the event
- deploy() project
deploy():
- Pulls from working tree, fresh clone if that fails (go-git doesn't support force pull)
- Run docker-compose using similar docker-in-docker workaround to daemon-up
A bunch of minor typo fixes, refactored some shared helper functions to util.go

Todo

🔦 Testing Instructions

inertia init
inertia remote add local 0.0.0.0 -u robertlin
docker build -t inertia .

This next thing basically bootstraps without pulling master inertia:

sudo docker run -p 8081:8081 -e HOME -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -v $HOME:/app/host -e SSH_KNOWN_HOSTS='/app/host/.ssh/known_hosts' -e HOME=$HOME --name="inertia-daemon" inertia

If needed, do docker rm -f $(docker ps -a -q)
Now you can:

inertia remote status local
inertia deploy local up
inertia deploy local down
inertia deploy local status

For example, with Sleuth:

Roberts-MacBook-Pro:inertia robertlin$ inertia deploy local up
(Status code 201) Project up

Roberts-MacBook-Pro:inertia robertlin$ inertia deploy local status
(Status code 200) 7b7be0b7097a26169e17037f4220fd0ce039bde1 refs/heads/master
Active containers:
project_frontend (/project_frontend_1)
project_web (/project_web_1)
project_solr (/project_solr_1)
postgres (/project_db_1)

Roberts-MacBook-Pro:inertia robertlin$ inertia deploy local down
(Status code 200) Project down

Roberts-MacBook-Pro:inertia robertlin$ inertia deploy local down
(Status code 412) No containers are currently active

Roberts-MacBook-Pro:inertia robertlin$ inertia deploy local status
(Status code 200) 7b7be0b7097a26169e17037f4220fd0ce039bde1 refs/heads/master
There are currently no active containers.

bobheadxi · 2017-12-26T09:52:30Z

+	err = CheckForGit()
+	if err != nil {
+		// Clone project
+		remoteURL := "" // TODO


Is this in config somewhere?

Try using getRepo and pull out the repo.Remotes() list. The information you want should be in there.

I think this particular case is for when CheckForGit() fails and I need to do a clone - wouldn't that mean there's either no repository at all, or that the repository has no remotes to do repo.Remotes() on?

Why don't we ship that info in the /up body? 😬

chadlagore · 2017-12-26T16:26:54Z

-// downHandler tries to bring the project down.
+// deploy does git pull, docker-compose build, docker-compose up
+func deploy(repo *git.Repository) error {
+	cfg, err := GetProjectConfigFromDisk()


This seems to be booting up the daemon? If this function is called, it's the daemon that called it 😂 Maybe this is just WIP.

chadlagore · 2017-12-26T16:29:39Z

+	}
+
+	w.Header().Set("Content-Type", "text/html")
+	w.WriteHeader(http.StatusOK)


201 - Created might be a nice return code here.

This is for shut down 😛 changed up to return created

Reviews on iPhones 🙈👍

chadlagore · 2017-12-26T16:31:50Z

+		http.Error(w, err.Error(), 501)
+	}
+	if len(containers) == 1 {
+		http.Error(w, "No Docker containers are currently active", 501)


Nice! Maybe a 412 - Precondition Failed works here.

chadlagore · 2017-12-26T16:32:57Z

+	}
+
+	// Take project offline
+	daemonCmd, err := Asset("cmd/bootstrap/project-down.sh")


Don't know if it's necessary to take the daemon down - if we do, they have to re-bootstrap the HTTP communication to continue using the server.

The script (project-down) looks like this:

DAEMON_NAME=inertia-daemon docker rm $(docker ps -a -q | grep -v "$DAEMON_NAME")

From what I understand this should leave the daemon alone right?

chadlagore · 2017-12-26T16:33:22Z

 	}

-	repo, err := git.NewFilesystemRepository(gitFolder)
+	repo, err := git.PlainOpen(gitFolder)


👍 Could not make this function work - silly git package.

chadlagore · 2017-12-27T03:46:44Z

@@ -0,0 +1,4 @@
+# Script for taking down all Docker containers except the Inertia daemon


Any reason you wouldn't use the golang docker client to handle this?

…e-daemon

chadlagore

Couple drive-by comments. Haven’t read the whole thing yet. But looking great! 🤩

I’d really like to avoid using bash to bring up the project! The bash work should be done once the server is bootstrapped. Is there a reason we can’t play with containers only using the go docker client?

chadlagore · 2018-01-01T00:39:43Z

 sudo docker run -d \
    -p "$PORT":8081 \
    -v /var/run/docker.sock:/var/run/docker.sock \
+    -v /usr/bin/docker:/usr/bin/docker \


As far as I can tell, there’s no guarantee this binary (installed for the host) works inside of the container (the container likely runs a different OS).

Haven’t had the opportunity to test that but I don’t see any indication that the container runs a different OS to the host with the way we’re starting the daemon up here, or maybe I jut don’t understand docker 😅 I’ll look into it

Looks like the container should be the same as the host:

Docker originally used LinuX Containers (LXC), but later switched to runC (formerly known as libcontainer), which runs in the same operating system as its host. This allows it to share a lot of the host operating system resources.

source

The first comment to that thread:

Ken, in some places you conflate the OS with the kernel. All containers on a host run under the same kernel, but the rest of the OS files can be unique per container.

One host kernel is orchestrating our container processes here. But each container we run via the host may use a different OS. Here is the example in inertia's case (say we've just allocated a gcloud vps with ubuntu installed on it):

We boostrap the VPS (installing docker via this).

It figures out what operating system its running on and installs docker for that OS.

You mount that binary into the daemon (running Alpine Linux).

Theres no guarantee that the binary is executable on Alpine Linux! 🙈

Heres a working example (pretending the host is running macOS 😂):

~/git/tmp master ✔ ▶ cp `which docker` . ~/git/tmp master ✗ ▶ docker run -it -v `pwd`:/home alpine / $ ls bin dev etc home lib media mnt proc root run sbin srv sys tmp usr var / $ cd home /home $ ls docker /home $ ./docker ./docker: line 1: ��: not found ./docker: line 2: @��__gosymtab__TEXT��__gopclntab__TEXT��5�A��__cstring__TEXT�t�l�t�__const__TEXTP: not found ./docker: line 2: ��P: not found ./docker: line 2: �__unwind_info__TEXT �� __eh_frame__TEXT��-��h__DATA��: not found ./docker: line 2: ��,: not found ./docker: line 2: �H__PAGEZER__TEXT�� __text__TEXT#n�#�__stubs__TEXTn��n�__stub_helper__TEXTD�D��__rodata__TEXT�__typelink__TEXT: not found ./docker: line 3: ��: not found ./docker: line 4: syntax error: unexpected word (expecting ")") /home $

Hang on, I've been mounting my local (macOS) installation into the daemon, should that not be working?

You don't appear to be using the docker binary anywhere in this PR. That's probably why it works.

The go docker library does everything you need, it never has to access a docker binary in a file somewhere, all it needs is to look at /var/run/docker.sock and find a socket there 😄 - which we provide with -v /var/run/docker.sock:/var/run/docker.sock.

I think we can just remove the -v /usr/bin/docker:/usr/bin/docker here. It's not doing anything and it would break if we tried to actually use it somewhere.

Oh yeah you're right, was using the docker binary for back when I was still using the shell script - not needed anymore

Speaking of which running that project-up.sh script was working before and I think that used the mounted docker binary?

Not sure! It may work sporadically, if we happen to use a host compatible with Alpine - but in general we can't assume that a binary built from source in one OS will work inside other OS.

chadlagore · 2018-01-01T00:46:33Z

 	log.Println(fmt.Sprintf("Ref: %s", event.GetRef()))
+
+	// Clone repository if not available
+	err := checkForGit(projectDirectory)


chadlagore · 2018-01-01T00:49:27Z

+	}
+
+	w.Header().Set("Content-Type", "text/html")
+	w.WriteHeader(http.StatusOK)


Reviews on iPhones 🙈👍

bobheadxi · 2018-01-01T01:20:49Z

Thanks @chadlagore !

The main problem is docker-compose has to be installed separately from Docker, and the Go Docker client doesn't offer docker-compose actions. Hence the bash hack, which should install a docker-compose image and run it as a container, allowing it to be platform agnostic:

docker run -d \
    -v /var/run/docker.sock:/var/run/docker.sock \
    -v $HOME:/build \
    -w="/build/project" \
    docker/compose:1.18.0 up --build

Note I'm mounting all of $HOME here instead of just the project directory because of one particular pesky project (cough sleuth cough 😅 ) that requires "neighbouring" repositories.

Tried mounting docker-compose from host but it seems on MacOS at least it doesn't work, though from what I've read it /should/ work on Linux... just need to add this when bringing the daemon up:

    -v /usr/local/bin/docker-compose:/usr/local/bin/docker-compose

There is a docker client for docker-compose in Go that I wanted to try but believe it or not, it currently has a dependency clash with the normal go docker client resulting from a case change (capital S vs lowercase s in something) 😠 I didn’t look too much into it because I thought there would still be the issue about the lack of docker-compose installation

bobheadxi · 2018-01-01T13:07:37Z

@chadlagore got rid of the project-up script ✨

Chad/#38 authorization

chadlagore · 2018-01-04T19:01:55Z

+		return err
+	}
+
+	println(token)


This is my fault - 🔫

bobheadxi · 2018-01-04T21:35:25Z

Forgot in the commit message but 40ba979 also compares the remote URL of requests (e.g. from up or from webhook events) and fails if they dont match the git repository on daemon

Hotfix the config writer; unexport initialization functions

bobheadxi · 2018-01-07T00:35:41Z

Thanks @chadlagore !

inertia robertlin$ go test ./cmd -cover
ok      github.com/ubclaunchpad/inertia/cmd     0.017s  coverage: 19.2% of statements

chadlagore · 2018-01-07T02:05:00Z

-sudo chmod +x $DOCKER_COMPOSE_DEST
-
-# Try using.
-docker-compose --version


bobheadxi · 2018-01-07T16:12:17Z

Note some of the tooltip updates in 718645c might be for #48 😅

chadlagore · 2018-01-07T16:13:30Z

    ssh-keygen -f $ID_DESTINATION -t rsa -N ''
 fi

+ssh-keyscan github.com >> ~/.ssh/known_hosts


chadlagore · 2018-01-07T16:15:10Z

+		println("It is recommended that you DO NOT commit this folder in source")
+		println("control since it will be used to store sensitive information.")
+		println("\nYou can now use 'inertia remote add' to connect your remote")
+		println("VPS instance.")


chadlagore · 2018-01-07T16:16:16Z

+
+	assert.Equal(t, sshURL, getSSHRemoteURL(httpsURL))
+	assert.Equal(t, sshURL, getSSHRemoteURL(sshURL))
+}


👏 for regression tests!

chadlagore · 2018-01-07T16:21:52Z

 sudo docker run --rm \
    -v $HOME:/app/host \
-    -e SSH_KNOWN_HOSTS=$SSH_KNOWN_HOSTS \
+    -e SSH_KNOWN_HOSTS='/app/host/.ssh/known_hosts' \


🤦‍♂️

chadlagore

+1 best code 🏅

Deployed my project:

~/git/inertia-deploy-test  master ✗                                                                                                                                           6m ◒
▶ ./inertia deploy gcloud up
(Status code 201) Project up

~/git/inertia-deploy-test  master ✗                                                                                                                                           6m ◒
▶ ./inertia deploy gcloud status
(Status code 200) git@github.com:chadlagore/inertia-deploy-test.git
b3bc12a2f816f727be550dd05759144a0abf0ffa refs/heads/master
Active containers:
python (/project_webdev_1)

Looks totally awesome:

For the record, we keep getting this error:

▶ ./inertia deploy gcloud up
(Status code 500) Unknown response from daemon: Error response from daemon: Conflict. The container name "/docker-compose" is already in use by container "9e223216098ede70e100ea8de80e472943aa6e7afcde91c746790951d679e22f". You have to remove (or rename) that container to be able to reuse that name.

And we're not in love with this chunk:

   // Check if build failed abruptly
    time.Sleep(2 * time.Second)
    _, err = getActiveContainers(cli)
    if err != nil {
        err := killActiveContainers(cli)
        return errors.New("Docker-compose failed: " + err.Error())
    }

And we know it breaks when the project expects its images to have docker-compose canonical names.

But this thing works for straightforward docker-compose projects 👍

bobheadxi added 2 commits December 26, 2017 16:49

Merge branch 'chad/#24-dockerize-daemon' into rob/#27-serverside-daemon

737b52c

Work in progress daemon up and down

2c61a35

bobheadxi added the pr: wip in progress but seeking feedback label Dec 26, 2017

bobheadxi commented Dec 26, 2017

View reviewed changes

Cleanup

ae22b02

bobheadxi requested a review from chadlagore December 26, 2017 09:57

chadlagore reviewed Dec 26, 2017

View reviewed changes

Fix init, update response codes, other tweaks

83f498f

chadlagore reviewed Dec 27, 2017

View reviewed changes

chadlagore and others added 7 commits December 26, 2017 20:47

Add repo to post request

0871b3b

Merge branch 'chad/32-get-repo-name-to-daemon' into rob/#27-serversid…

c7c1fd2

…e-daemon

Update cloning auth, use Go Docker client for container shutdown, fixes

73e7534

Fixed Daemon clone/pull, new mounts on daemon-up, push SSH URL on up

3b8cac9

Refactor common helper functions into util.go and minor cleanup

9e49206

Docker-compose, updated error codes, clone from push event

7dbe8d6

Remove test repository

970eef5

bobheadxi added the pr: finalized needs review and final approval label Dec 31, 2017

bobheadxi requested review from bfbachmann, chadlagore and jordanschalm December 31, 2017 07:01

chadlagore reviewed Jan 1, 2018

View reviewed changes

bobheadxi added 2 commits January 1, 2018 11:03

Check if remote URL is already an SSH remote

b636049

Use docker client instead of script, new 'deploy status' command, fixes

184836e

Fix 'remote down' error when no containers active

6952550

chadlagore and others added 3 commits January 3, 2018 20:15

Remove redundant comments

b4edddc

Merge branch 'rob/#27-serverside-daemon' into chad/#38-authorization

9450e96

Merge pull request #39 from ubclaunchpad/chad/#38-authorization

7203f3e

Chad/#38 authorization

chadlagore reviewed Jan 4, 2018

View reviewed changes

Comment thread cmd/remote.go Outdated

return err

}

println(token)

chadlagore Jan 4, 2018

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my fault - 🔫

chadlagore mentioned this pull request Jan 4, 2018

Create a Testing Container That Acts Like a Remote #40

Closed

Add authorization headers, add 'deploy reset', reorganize daemon

40ba979

bobheadxi changed the title ~~inertia deploy [REMOTE] up, down, status~~ inertia deploy [REMOTE] (up, down, status, reset) and authentication Jan 4, 2018

Deploy tests, updated other tests, remove binary

129cb90

bobheadxi requested a review from chadlagore January 6, 2018 22:17

bobheadxi and others added 4 commits January 6, 2018 14:23

Remove docker-compose installation from bootstrap

d7ece6a

Remove binary for real

8e00434

Fix deploy, complete deploy tests

8966ffa

Hotfix the config writer; unexport initialization functions

81d6b5a

bobheadxi mentioned this pull request Jan 7, 2018

'inertia [REMOTE] [COMMAND]' #48

Merged

Merge pull request #47 from ubclaunchpad/chad/hotfix-config-writes

2e62259

Hotfix the config writer; unexport initialization functions

chadlagore reviewed Jan 7, 2018

View reviewed changes

Fix ssh known_hosts bug, add post-deploy check, improve tooltips

718645c

chadlagore reviewed Jan 7, 2018

View reviewed changes

bobheadxi added 2 commits January 7, 2018 08:42

Kill docker-compose more consistently

9759e5a

Sleep so clone can hopefully complete, increase docker-compose wait

375e6bf

chadlagore approved these changes Jan 7, 2018

View reviewed changes

bobheadxi merged commit 9bc08c4 into master Jan 7, 2018

bobheadxi deleted the rob/#27-serverside-daemon branch January 7, 2018 17:33

chadlagore mentioned this pull request Jan 14, 2018

Dockerize Testing Environment #23

Closed

		@@ -0,0 +1,4 @@
		# Script for taking down all Docker containers except the Inertia daemon

Conversation

bobheadxi commented Dec 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Changes

Todo

🔦 Testing Instructions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bobheadxi Dec 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bobheadxi Dec 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chadlagore Dec 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chadlagore left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bobheadxi commented Jan 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bobheadxi commented Jan 1, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bobheadxi commented Jan 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bobheadxi commented Jan 7, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bobheadxi commented Jan 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chadlagore Jan 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

bobheadxi commented Dec 26, 2017 •

edited

Loading

bobheadxi Dec 27, 2017 •

edited

Loading

bobheadxi Dec 27, 2017 •

edited

Loading

chadlagore Dec 26, 2017 •

edited

Loading

bobheadxi commented Jan 1, 2018 •

edited

Loading

bobheadxi commented Jan 4, 2018 •

edited

Loading

bobheadxi commented Jan 7, 2018 •

edited

Loading

chadlagore Jan 7, 2018 •

edited

Loading