Chad/#38 authorization#39
Merged
Merged
Conversation
bobheadxi
reviewed
Jan 4, 2018
|
|
||
| // getGithubKey returns the key generated by 'inertia remote bootstrap [REMOTE]' | ||
| func getGithubKey() (ssh.AuthMethod, error) { | ||
| pemFile := "/app/host/.ssh/id_rsa_inertia_deploy" |
Member
There was a problem hiding this comment.
A bit hesitant about putting this function in util since that path (/app/host/...) applies specifically to the daemon container
Contributor
Author
There was a problem hiding this comment.
Mmmm. How about we make this function more general? getKeyFromPem(pemFile string). Then we could possibly unit test it too.
Contributor
Author
There was a problem hiding this comment.
Actually I think this is the "go" way to write testable code that does file IO. Something like
func getKeyFromPem(pemFile io.Reader)
Contributor
Author
There was a problem hiding this comment.
I can move it back for the time being 👍 Something to think about.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⌛ Status: Ready for review
🎟️ Ticket(s): #38
👷 Changes
authorizationfunction decorator.🔦 Testing Instructions
go test ./cmd -cover