Conversation
| { | ||
| // without performing validation : expect to receive a 401 | ||
| // ensure user is logged out | ||
| self::$xdmodhelper->logoutDashboard(); |
There was a problem hiding this comment.
Why logoutDashboard instead of just logout?
There was a problem hiding this comment.
I see, because this is testing the internal dashboard. I would recommend authenticateDashboard instead of authenticate then.
There was a problem hiding this comment.
So after a little bit of digging, it seems that the logout/authenticate (without Dashboard) is probably more desirable here. The authenticateDashboard does not work for these REST calls because even though they are in the internal dashboard, endpoints tested here such as supremm_dataflow/dbstats are part of the new REST stack. I need to double-check, but it seems that the {logout,authenticate}Dashboard does not properly authenticate the user for the required REST calls.
There was a problem hiding this comment.
In DashboardSupremmTest, Instead of logging out at the top of functions, I would recommend that for each call to authenticate there is a corresponding call to logout that happens after the request(s) have been made. In most cases, the logout would be after a single call to get, except for testResourceEnableDisable in which it would be after the three calls to get. The goal would be that each test resets the state back to where it found it.
|
Closed in favor of #391 |
This is identical to #390 (see writeup in that PR). There was an issue with my CircleCI account where it was running the tests under my own account and not under the
ubccraccount. I made a config change that resolves the issue, but it requires a new PR to apply the change.Description
Motivation and Context
Tests performed
Types of changes
Checklist: