Fix tests and add missing exception testing.#391
Closed
aaronweeden wants to merge 16 commits intoubccr:xdmod11.0from
Closed
Fix tests and add missing exception testing.#391aaronweeden wants to merge 16 commits intoubccr:xdmod11.0from
aaronweeden wants to merge 16 commits intoubccr:xdmod11.0from
Conversation
jpwhite4
previously approved these changes
Aug 21, 2024
3 tasks
cf933e4 to
713da94
Compare
d3d872b to
3352fae
Compare
Co-authored-by: Conner Saeli <connersa@buffalo.edu>
rather than at the end, so you don't have to wait as long for failure. Also store all of the files from /root/xdmod/logs for debugging.
5d1acb6 to
ba5a599
Compare
6 tasks
Contributor
Author
|
Closed in favor of #434. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds CircleCI testing for exceptions logged to
logs/exceptions.login the checked outxdmodrepository. For example, an exception caused by a bug in integration test code might be echoed to stderr and written tologs/exceptions.logbut not causephpunitto fail, and thus CircleCI would not fail.This PR fixes the bugs that are exposed by this change.
There is also a PR for ubccr/xdmod#1903.
Tests performed
I tested the exceptions testing, confirmed the CircleCI build fails, and fixed the bugs.
Types of changes
Checklist: