Skip to content

Raise runtime error if raw data stream is closed unexpectedly.#73

Merged
aaronweeden merged 34 commits intoubccr:v1.x.yfrom
aaronweeden:fix-raw-data
Jul 15, 2025
Merged

Raise runtime error if raw data stream is closed unexpectedly.#73
aaronweeden merged 34 commits intoubccr:v1.x.yfrom
aaronweeden:fix-raw-data

Conversation

@aaronweeden
Copy link
Copy Markdown

@aaronweeden aaronweeden commented Apr 25, 2025

Description

This PR updates the get_raw_data() method to handle receiving data with chunked transfer encoding to support ubccr/xdmod#2032. This allows it to be detected when the connection is closed before all the rows are sent. This PR adds a raised RuntimeError when this occurs.

This PR also fixes the automated tests to make sure the development versions of XDMoD are actually tested; this was silently failing before (tests/ci/scripts/run-tests.sh is also updated to 4 spaces to be consistent with other files).

This PR also updates the development instructions to remove the unnecessary instruction to increment the development release number.

Tests performed

Updated the regression tests.

Type of change:

  • Refactoring / documentation update (non-breaking change which does not change functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release preparation

Checklist:

  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request
  • Updates have been made to the xdmod-notebooks repository as necessary, and the notebooks all run successfully

@aaronweeden aaronweeden changed the title Warn if raw data stream is closed unexpectedly. Throw exception if raw data stream is closed unexpectedly. Jul 2, 2025
@aaronweeden aaronweeden changed the title Throw exception if raw data stream is closed unexpectedly. Raise runtime error if raw data stream is closed unexpectedly. Jul 2, 2025
@aaronweeden aaronweeden marked this pull request as ready for review July 15, 2025 14:55
@connersaeli connersaeli self-requested a review July 15, 2025 19:30
@aaronweeden aaronweeden merged commit 7ea637e into ubccr:v1.x.y Jul 15, 2025
2 checks passed
@aaronweeden aaronweeden deleted the fix-raw-data branch July 15, 2025 19:45
aaronweeden added a commit to aaronweeden/xdmod-data that referenced this pull request Jul 15, 2025
@aaronweeden aaronweeden added bug Something isn't working and removed refactor Refactor of existing functionality labels Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants