Raise runtime error if raw data stream is closed unexpectedly.#73
Merged
aaronweeden merged 34 commits intoubccr:v1.x.yfrom Jul 15, 2025
Merged
Raise runtime error if raw data stream is closed unexpectedly.#73aaronweeden merged 34 commits intoubccr:v1.x.yfrom
aaronweeden merged 34 commits intoubccr:v1.x.yfrom
Conversation
3 tasks
connersaeli
approved these changes
Jul 15, 2025
aaronweeden
added a commit
to aaronweeden/xdmod-data
that referenced
this pull request
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
get_raw_data()method to handle receiving data with chunked transfer encoding to support ubccr/xdmod#2032. This allows it to be detected when the connection is closed before all the rows are sent. This PR adds a raisedRuntimeErrorwhen this occurs.This PR also fixes the automated tests to make sure the development versions of XDMoD are actually tested; this was silently failing before (
tests/ci/scripts/run-tests.shis also updated to 4 spaces to be consistent with other files).This PR also updates the development instructions to remove the unnecessary instruction to increment the development release number.
Tests performed
Updated the regression tests.
Type of change:
Checklist:
xdmod-notebooksrepository as necessary, and the notebooks all run successfully