Plotly JS charts now consider timezones#2031
Merged
aestoltm merged 5 commits intoubccr:mainfrom Apr 24, 2025
Merged
Conversation
ryanrath
previously approved these changes
Apr 23, 2025
ryanrath
approved these changes
Apr 24, 2025
aaronweeden
pushed a commit
to aaronweeden/xdmod
that referenced
this pull request
May 23, 2025
* Added timezone conversion to Plotly JS charts. Should have been included in original conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Should have been in original conversion (PR #1822). This update makes all XDMoD charts timezone aware. Plotly JS does not support timezones. Therefore, moment js was utilized to convert the dates to the web server's timezone.
This bug was found by @ryanrath and Shava. The the following chart, exposes the bug for 'America/Los_Angeles' vs 'America/New_York' timezones.
Note: Job Viewer charts were already timezone aware because they are created through a separate mechanism than all other XDMoD charts.
Motivation and Context
Wrong date range shown on the plot depending on the data time range and client's timezone.
Tests performed
Tested the chart linked across various timezones. (See here for more details on changing timezone)
Checklist: