Use xdmod10.5 logic for enabling markers#1997
Merged
aestoltm merged 4 commits intoubccr:xdmod11.0from Mar 6, 2025
Merged
Conversation
…ght I did this in ubccr#1941 but it is not the same logic.
… can connect multiple non-null values
aaronweeden
previously approved these changes
Mar 6, 2025
aaronweeden
reviewed
Mar 6, 2025
| break; | ||
| } | ||
| } | ||
| if($allNull) |
Contributor
There was a problem hiding this comment.
Suggested change
| if($allNull) | |
| if($visiblePoints > 0) |
and can get rid of $allNull variable.
Contributor
Author
There was a problem hiding this comment.
I think it should be if($visiblePoints == 0) so that we know its "allNull" and can skip.
aaronweeden
approved these changes
Mar 6, 2025
aaronweeden
pushed a commit
to aaronweeden/xdmod
that referenced
this pull request
Mar 7, 2025
* Use xdmod10.5 implementation of deciding when to show markers. I thought I did this in ubccr#1941 but it is not the same logic.
aaronweeden
pushed a commit
to aaronweeden/xdmod
that referenced
this pull request
Mar 7, 2025
* Use xdmod10.5 implementation of deciding when to show markers. I thought I did this in ubccr#1941 but it is not the same logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@aaronweeden found examples where series incorrectly had markers rendered. I looked at the changes make in #1941 and noticed it did not use the same marker logic as in xdmod10.5 (highcharts implementation) which matches our desired behavior. This PR corrects the logic that enables markers to be the same as in 10.5 timeseries and aggregate charts
Motivation and Context
Improve the clarity of charts. The incorrectly rendered markers made it difficult to see other series on the same date.
Tests performed
Tested on my dev port.
Checklist: