Refactor timeseries ticklabels#1992
Merged
aestoltm merged 16 commits intoubccr:xdmod11.0from Mar 6, 2025
Merged
Conversation
aestoltm
commented
Mar 6, 2025
| (isset($meChart['layout']['xaxis']['ticktext']) || isset($meChart['layout']['yaxis']['ticktext'])) | ||
| && $chartSortedByValue | ||
| && $usageGroupBy !== 'none' | ||
| && !$meRequestIsTimeseries |
Contributor
Author
There was a problem hiding this comment.
Need this so that we do not rank our timeseries ticklabels. Was not a concern before because we did not make use of ticktext and tickvals for timeseries charts.
aaronweeden
approved these changes
Mar 6, 2025
aaronweeden
pushed a commit
to aaronweeden/xdmod
that referenced
this pull request
Mar 7, 2025
* Render timeseries tick labels based on a computed `dtick`. Tick labels will only render for the data points specified in `tickvals`
aaronweeden
added a commit
that referenced
this pull request
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Compute the placement and format of ticklabels using
tickvalsandticktext. This gives us full control of which tick labels are rendered and their values. This is necessary to have the first and last label of the data always showing, along with not having any labels outside of the selected time range. These changes result in not needing to remove any extra tick labels because we dictate what is rendered.Motivation and Context
Avoid any confusion about data existing outside the selected time range.
Tests performed
Tested on my port.
Checklist: