Use global min/max when removing excess date ticklables#1988
Merged
aestoltm merged 9 commits intoubccr:xdmod11.0from Feb 21, 2025
Merged
Use global min/max when removing excess date ticklables#1988aestoltm merged 9 commits intoubccr:xdmod11.0from
aestoltm merged 9 commits intoubccr:xdmod11.0from
Conversation
aaronweeden
reviewed
Feb 20, 2025
aaronweeden
reviewed
Feb 21, 2025
aaronweeden
approved these changes
Feb 21, 2025
aestoltm
added a commit
to aestoltm/xdmod
that referenced
this pull request
Feb 21, 2025
aaronweeden
pushed a commit
to aaronweeden/xdmod
that referenced
this pull request
Feb 21, 2025
* Use global min/max
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partial data series can trick the current implementation into incorrectly removing datetime tick labels if the data is the first data point and does not contain the global minimum and/or maximum of the dataset.
Motivation and Context
This can cause issues viewing timeseries charts. Resulting in missing/incomplete datetime tick lables
Tests performed
Tested on my dev port
Checklist: