Fix issues with swap XY axis.#1961
Merged
jpwhite4 merged 3 commits intoubccr:xdmod11.0from Feb 7, 2025
Merged
Conversation
This pull request addresses multiple issues with swapping the X-Y axis. 1) Incorrect Y-axis legend configuration when there are multple datasets using diffent axes 2) Corrupted x-axis legend configuration when "show remainder disable paging" is selected.
eiffel777
approved these changes
Jan 30, 2025
aaronweeden
pushed a commit
to aaronweeden/xdmod
that referenced
this pull request
Feb 10, 2025
Fix issues with swap XY axis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses multiple issues with swapping the X-Y axis.
Before (note the wrong title on the y-axis and the vertical misalignment of the data, and the incorrect data ordering):
After:
Before (note the messed up x-axis):
After:
Description
The change to fix problem (1) is to update the swap axis code to swap the correct axes!
The change for fix problem (2) involves moving the call to truncate the datasets to before the chart configuration is attempted. The chart truncate causes the categorical axis to be regenerated. When this was happening during the chart config with swap XY enabled then the chart layout config was getting corrupted. There is no need to compute/store the
$dataSeriesSummarizedvariable - you know whether a dataset can be drilled down based on the ID value.