Fix how pdoAggregator logs the day that was aggregated.#1932
Merged
aaronweeden merged 2 commits intoubccr:xdmod11.0from Feb 7, 2025
Merged
Fix how pdoAggregator logs the day that was aggregated.#1932aaronweeden merged 2 commits intoubccr:xdmod11.0from
pdoAggregator logs the day that was aggregated.#1932aaronweeden merged 2 commits intoubccr:xdmod11.0from
Conversation
b6a2e2b to
a779c92
Compare
Member
|
is this supposed to go into 11.0.1 or 11.5.0? |
a779c92 to
3e021c1
Compare
jpwhite4
approved these changes
Feb 7, 2025
fa06dd6 to
e03a2f9
Compare
aaronweeden
added a commit
to aaronweeden/xdmod
that referenced
this pull request
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, if
pdoAggregatoris used to aggregate a single day, the day it displays in the log is off by one. I noticed this when manually aggregating a day (2016-11-01) of Gateways data:That should instead be
01 11 2016.This is because the
Y00zformat string counts days of the year starting at zero, but MySQLDAYOFYEARcounts starting at one.This PR fixes how the day is displayed. It also changes the format to match what is used often elsewhere,
Y-m-d.Tests performed
Tested by aggregating a day of Gateways records on
xdmod-devand confirming the displayed day is correct.Checklist: