Add missing endpoint to exception message in ExecuteSql.#1929
Merged
aaronweeden merged 1 commit intoubccr:xdmod11.0from Feb 4, 2025
Merged
Add missing endpoint to exception message in ExecuteSql.#1929aaronweeden merged 1 commit intoubccr:xdmod11.0from
ExecuteSql.#1929aaronweeden merged 1 commit intoubccr:xdmod11.0from
Conversation
Member
|
Is the milestone correct for this pull request? |
73856ae to
63e6808
Compare
eiffel777
approved these changes
Jan 30, 2025
15a7396 to
9fcc6d3
Compare
aaronweeden
added a commit
to aaronweeden/xdmod
that referenced
this pull request
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ETL maintenance class
ExecuteSqlonly usesdestinationEndpoint, notsourceEndpoint. However, when exceptions are logged, it tries to report thesourceEndpoint. This PR fixes this to instead report thedestinationEndpoint.Tests performed
I ran an SQL query on my port on
xdmod-devthat I knew was incorrect, and it reported the following (note that the endpoint is not reported):Then I applied the fix, ran it again, and the endpoint is now reported in the exception:
Checklist: