Enhance the tasks in tomcat.gradle by adding logical 'mustRunAfter' r…#112
Merged
drewwills merged 2 commits intoFeb 15, 2018
Merged
Conversation
…elationships for tasks that could potentially be in the Task Graph
ChristianMurphy
approved these changes
Feb 15, 2018
…elationships for tasks that could potentially be in the Task Graph (grammar & format updates)
bjagg
added a commit
to bjagg/uPortal-start
that referenced
this pull request
May 14, 2026
Problem: PR uPortal-Project#694's visual-resource-server smoke spec gates on no /ResourceServingWebapp/ URLs being requested by uPortal core or any of the deployed portlets. The pins were on versions predating both the uPortal-side path swaps (uPortal-Project/uPortal#2983, in v5.17.8) and the portlet-side overlay drops (SimpleContent uPortal-Project#554, Feedback uPortal-Project#112, NewsReader uPortal-Project#438; in 3.4.3 / 1.3.2 / 5.1.5 respectively). CI's visual smoke tests therefore stayed red until all five releases shipped together. Goal: pick up the Wave 1 portlet releases and the Wave 2 uPortal release so PR uPortal-Project#694's CI exercises the full post-consolidation stack. Changes: - bump uPortalVersion 5.17.7 -> 5.17.8 (uPortal#2983: skin XML + JSP path swaps off /ResourceServingWebapp/; drop dead utility-lib webjar deps) - bump simpleContentPortletVersion 3.4.2 -> 3.4.3 (uPortal-Project#554: CKEditor 4.22.1 webjar; drop resource-server-content overlay) - bump feedbackPortletVersion 1.3.1 -> 1.3.2 (uPortal-Project#112: drop overlay) - bump newsReaderPortletVersion 5.1.4 -> 5.1.5 (uPortal-Project#438: native mini-template renderer replacing Handlebars 3.0.3; drop overlay) Notes: validated locally against a fresh portalInit + tomcatStart with the bumped pins. Five of six visual-resource-server tests pass (guest welcome, admin home, student home, CKEditor 4 webjar instantiation, uportal-links config). The news-portlet-renders-without-Handlebars test was already failing in CI before this commit; not a regression from the bumps. CalendarPortlet event-fetch is flaky in local quickstart data; tracked separately. Refs: uPortal-Project#694
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…elationships for tasks that could potentially be in the Task Graph
Checklist
Description of change
In
uPortal-start, it is often convenient to chain 2 or more Gradle tasks together, e.g....But when
tomcatStartis in the chain, there's a pretty good likelihood that there will be other tasks in the Gradle Task Graph (e.g.tomcatDeployordataInit) that really need to complete beforetomcatStarteven begins.This change adds
mustRunAfterrelationships to (primarily)tomcatStartso that chaining Gradle tasks together will work as intended.