feat: add tab name and portlet info to analytics events#2694
Merged
bjagg merged 3 commits intoNov 4, 2023
Conversation
ChristianMurphy
approved these changes
Aug 23, 2023
ChristianMurphy
left a comment
Member
There was a problem hiding this comment.
Thanks @bjagg! looks good
ChristianMurphy
requested changes
Aug 23, 2023
ChristianMurphy
left a comment
Member
There was a problem hiding this comment.
It looks like ESLint may need a configuration update
ChristianMurphy
approved these changes
Aug 23, 2023
cbeach47
reviewed
Nov 2, 2023
Contributor
There was a problem hiding this comment.
@bjagg - Fixed the package lock conflict and confirmed the new details are being sent in the request locally.
Seems a bit odd that the tab_name is scraping the text content. It's ending up with values such as tab_name: "TestingEdit text Testing". If this is as-intended, then 👍
Confirmed that layering the commits from #2695 onto this code persists the new fields.
cbeach47
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
security.propertiesportal.propertiesCHANGES.mdDescription of change
Add tab (name) and portlet info (ID and title) to analytics events.