Skip to content

feat/AnalyticsEventUpdate add new features to AnalyticsPortalEvent an…#2695

Merged
bjagg merged 2 commits into
uPortal-Project:masterfrom
mgillian:feat/AnalyticsEventUpdate
Nov 4, 2023
Merged

feat/AnalyticsEventUpdate add new features to AnalyticsPortalEvent an…#2695
bjagg merged 2 commits into
uPortal-Project:masterfrom
mgillian:feat/AnalyticsEventUpdate

Conversation

@mgillian

Copy link
Copy Markdown
Contributor

…d factory

Checklist
Description of change

Additional data is captured as part of an AnalyticsPortalEvent being generated by the UI call to the AnalyticsPortalEventControlller REST endpoint

@ChristianMurphy ChristianMurphy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mgillian!
When you get a chance, please run ./gradlew goJF to format the code so CI passes, thanks!

@ChristianMurphy ChristianMurphy requested review from ChristianMurphy and cbeach47 and removed request for ChristianMurphy November 2, 2023 21:00
ChristianMurphy

This comment was marked as duplicate.

@ChristianMurphy ChristianMurphy self-requested a review November 2, 2023 21:03

@ChristianMurphy ChristianMurphy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting looks good, I have not tested otherwised

@cbeach47 cbeach47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed locally on Java 11. LGTM 👍

@bjagg bjagg merged commit 442d1c5 into uPortal-Project:master Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants