Skip to content
This repository was archived by the owner on Sep 9, 2022. It is now read-only.

Goodnight, sweet prince.#1157

Closed
ghost wants to merge 3 commits intomasterfrom
unknown repository
Closed

Goodnight, sweet prince.#1157
ghost wants to merge 3 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Apr 2, 2015

Thanks for all of your hard work @gorhill and @Deathamns. We greatly
appreciate everything you did. Good luck to @chrisaljoudi.

Your Name added 2 commits April 1, 2015 20:17
Thanks for all of your hard work @gorhill and @Deathamns. We greatly
appreciate everything you did. Good luck to @chrisaljoudi.
@chrisaljoudi
Copy link
Contributor

This is incredibly helpful, @hotdogman. Thank you. Will merge momentarily.

@ghost
Copy link
Author

ghost commented Apr 2, 2015

Will merge momentarily.

You might want to review before doing that. It looks like this modified Info.plist for Safari, which might complicate auto-updating and other things. I don't know, I haven't used Safari.

Thank you.

I'm just glad I was able to do something semi-useful.

For future reference (if needed):
find * -type f -exec grep -Il . {} \; -exec sed -i 's/old/new/g' {} \;
find * -type f -exec grep -Il . {} \; -exec sed -i 's/gorhill/chrisaljoudi/g' {} \;

@ajs124
Copy link

ajs124 commented Apr 2, 2015

On the topic of rebranding: There are still quite some "µ"s in there, most of them in the javascript, but apparently some are also in the translations. See for example here or here.

@ghost
Copy link
Author

ghost commented Apr 2, 2015

There are still quite some "µ"s in there

find * -type f -exec grep -Il . {} \; -exec sed -i 's/µ/u/g' {} \;
#1073

@ajs124
Copy link

ajs124 commented Apr 2, 2015

There are several problems with that approach. First thing, some languages use µ, it's a normal character with a normal usage in them. Second, there are (at least) two Unicode symbols in this codebase that look like this "µ". The greek letter Mu and the Micro sign.

chrisaljoudi added a commit that referenced this pull request Apr 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants