Remove the exec bit from builtin.go #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rminnich
approved these changes
Jan 18, 2017
hugelgupf
pushed a commit
to hugelgupf/u-root
that referenced
this pull request
Jun 7, 2019
* localboot: add multiboot support Enables localboot to handle multiboot menu entries using kexeec support for multiboot Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * review fixes Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * review: rework ScanGrubConfigs Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * fix bootconfig struct tag Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * review: add safeguard to recursive grub.cfg search Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * localboot: add multiboot support Enables localboot to handle multiboot menu entries using kexeec support for multiboot Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * initial draft, support for vfat and ext4 Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * add config flag to selct bootconfig Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * fix rebase Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * rework bootconfig.go due to new mulitboot interface Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * fix rebase Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * localboot/grub.go: rework fsuuid validation Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * localboot/grub.go: reset kernelBaseDir for every grub menuentry Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * rework measurement of bootconfigs Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * clean up comments Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * crypto: remove TryMeasureBootconfig() Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com> * storage/blockdev.go: fix PartitionsByFsUUID Signed-off-by: Jens Drenhaus <jens.drenhaus@9elements.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In github, you can see where it says "100755 → 100644" on the file. That means the exec bit is removed.
The go source file does not require exec bits. Correct me if I'm wrong and I will add a comment explaining why this file requires an exec bit.
Additionally, this commit removes the misleading docstring on the package. I think it was a copy-paste error. I will come up with a man-page for it when I do another run-through on the man pages.