Skip to content

Consider all lookups and subtables in subs / sups coverage checks#7462

Merged
laurmaedje merged 1 commit intomainfrom
minimal-sups-fix
Nov 25, 2025
Merged

Consider all lookups and subtables in subs / sups coverage checks#7462
laurmaedje merged 1 commit intomainfrom
minimal-sups-fix

Conversation

@laurmaedje
Copy link
Member

This is a minimized version of #7258. It's not as comprehensive, but minimal and thus suitable for backporting. PR #7258 is a rather large change and a bit too dangerous for inclusion in a patch release.

Fixes #7249

Co-Authored-By: Malo <57839069+MDLC01@users.noreply.github.com>
@laurmaedje laurmaedje added text Related to the text category, which is all about text handling, shaping, etc. fix A bug fix. labels Nov 25, 2025
@laurmaedje laurmaedje requested a review from MDLC01 November 25, 2025 10:51
Copy link
Collaborator

@MDLC01 MDLC01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a correct fix for the current imperfect method.

As mentioned in #7258 (comment), this is probably a good solution until someone finds a problem with it.

Also, I don't remember where this was mentioned but there is precedent on testing whether a font supports a specific OpenType feature in Firefox, for small capitals with the CSS rule font-variant-caps: small-caps;. I'll try to look into how they do it when I get back to #7258.

@laurmaedje laurmaedje added this pull request to the merge queue Nov 25, 2025
Merged via the queue into main with commit 80b4aa4 Nov 25, 2025
16 checks passed
@laurmaedje laurmaedje deleted the minimal-sups-fix branch November 25, 2025 13:23
marrable pushed a commit to marrable/typst that referenced this pull request Nov 25, 2025
…typst#7462)

Co-authored-by: Malo <57839069+MDLC01@users.noreply.github.com>
laurmaedje added a commit that referenced this pull request Dec 2, 2025
…#7462)

Co-Authored-By: Malo <57839069+MDLC01@users.noreply.github.com>
@apcamargo
Copy link
Contributor

@laurmaedje I've been testing version 0.14.1 and found an issue with the Inter font when a closing parenthesis appears inside a superscript. The rendering is inconsistent compared to other parenthesis placements:

image

Do you think this could be related to this PR, or is it likely a separate issue? I could open a new issue specifically for this.

Source code
#set super(typographic: true)
  #set text(font: "Inter")
  Foo#super("test")
  Foo#super("test1")
  Foo#super("(test)1")
  Foo#super("test−1")
  Foo#super("(test)−1")
  Foo#super("(test−1)")
  Foo#super("(test)-1)")
  #super("()")#super("test")#super("1")

@laurmaedje
Copy link
Member Author

Please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A bug fix. text Related to the text category, which is all about text handling, shaping, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typst uses fake superscripts for some characters in Source Serif 4 despite available typographic glyphs

3 participants