Refactor sub- and superscript substitution#5120
Merged
laurmaedje merged 3 commits intotypst:mainfrom Oct 7, 2024
Merged
Conversation
Member
|
If I understand correctly, this will disable typographic superscripts completely if there's a space, right? That's kind of unfortunate considering the space doesn't really need a separate glyph to be shrinkable. |
Collaborator
Author
|
Indeed. There was more discussion on Discord on whether the typographic script feature even makes sense. I can revert the second commit and keep only the code quality improvements if you want (or close the PR completely). |
Member
|
We can keep the code quality improvements and discuss the rest for 0.13. |
Collaborator
Author
|
Done |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit contains some minor code quality improvements.
The second commit fixes #5112.