Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes two CJK punctuation mark from overhang machanism, for following reasons:
Punctuation hanging is not usually used in Chinese/Japanese
In Requirements for Chinese Text Layout, Section 3.1.7 Hanging Punctuation at Line End:
In Requirements for Japanese Text Layout, Section 3.8.2 Reduction and Addition of Inter-Character Spacing:
And the main usecase of LaTeX (and of cause Typst) is mixture of CJK and Latin script text. A search in GitHub shows that only 18 Japanese
texfile use the hanging punctuation.Punctuation hanging in Latin languages are fundamentally different from that in Chinese/Japanese.
Hanging punctuation in Chinese/Japanese is not a visual complement as in Latin languages. In Chinese/Japanese, it is a way of line adjustment to reduce the need to change inter-character spacing.
See Requirements for Japanese Text Layout, Section 3.8.2 Reduction and Addition of Inter-Character Spacing:

The 1st and 5th line is not hanged, because these lines need not any adjustment.