Conversation
|
Thank you! In addition, since this change is directly linked to typst/hayagriva#317, do you think you can adapt your PR on the hayagriva side to use these changes? You can use a git dependency on your biblatex fork for the time being so CI passes. The PRs can then be merged together.
Can you do this in a separate PR? Should be a speedy merge for that part then. |
Can do. I like the feature idea.
Yes, that was my next step. Just wanted to see the general reaction first. Thanks :)
Good point. See #79 |
Yeah, that's totally fair. Feel free to proceed with it then. |
|
While we're at it, it might be a good idea to supersede this PR by adding the I think the main difference from the
|
I added it. But should it also be a |
|
I suppose an invalid langid would probably be problematic in a LaTeX document using |
Co-authored-by: PgBiel <9021226+PgBiel@users.noreply.github.com>
Co-authored-by: PgBiel <9021226+PgBiel@users.noreply.github.com>
Co-authored-by: PgBiel <9021226+PgBiel@users.noreply.github.com>
Co-authored-by: PgBiel <9021226+PgBiel@users.noreply.github.com>
Co-authored-by: PgBiel <9021226+PgBiel@users.noreply.github.com>
Co-authored-by: PgBiel <9021226+PgBiel@users.noreply.github.com>
Co-authored-by: PgBiel <9021226+PgBiel@users.noreply.github.com>
Co-authored-by: PgBiel <9021226+PgBiel@users.noreply.github.com>
|
Sorry for the typos! It's all ready now |
|
Thank you! 💙 |
As discussed by @PgBiel in typst/hayagriva#317 (comment), biblatex does not handle languages correctly: First, they can be a list and second, we should actually parse the language identifiers used. This PR does just that.
Also applies some clippy fixes and uses Rust 1.85 in the CI, just as Typst and hayagriva.