Map biblatex language to hayagriva#317
Conversation
PgBiel
left a comment
There was a problem hiding this comment.
Thanks! I think there are some things to work out.
|
This will conflict with #126, which has some important considerations. We should first check if there will be a conflict with those considerations. The idea of converting languages from biblatex's format has also been mentioned there. |
Is that PR still active? It seems like this PR might be a good first step and #126 is the eventual improvement. |
|
We don't have to go all the way that #126 did so far of translating dates and other parts of the entry based on the language, but we should at least make sure interop is correct. To this end, we might need changes on |
Co-authored-by: PgBiel <9021226+PgBiel@users.noreply.github.com>
|
Thanks! Can you add a quick local test which just prints the language? (Not sure if this would require changes to how csl-json is handled) |
|
I added a local test but a CSL-JSON test makes no sense, right? With CSL-JSON, we don't have any biblatex and therefore no conversion. Am I missing something? |
|
Yeah you're right, a bit of an oopsie on my part. Thanks! |
The language field of biblatex was previously ignored, which caused #292. This PR adds the conversion.
If the field is not a valid language identifier, we ignore it. This may be improved in the future.
Close #292