Skip to content

Annotate parameters of java.lang.AssertionError(String, Throwable) co…#28

Merged
wmdietl merged 2 commits intotypetools:masterfrom
eaftan:patch-1
Mar 12, 2020
Merged

Annotate parameters of java.lang.AssertionError(String, Throwable) co…#28
wmdietl merged 2 commits intotypetools:masterfrom
eaftan:patch-1

Conversation

@eaftan
Copy link
Copy Markdown

@eaftan eaftan commented Jan 27, 2020

…nstructor

The Javadoc for the constructor says both parameters may be null.

eaftan and others added 2 commits January 27, 2020 10:41
@eaftan
Annotate parameters of java.lang.AssertionError(String, Throwable) co…
3f6c098 
…nstructor

The Javadoc for the constructor says both parameters may be null.
@wmdietl
Add @SideEffectFree
6b88ba7
wmdietl added a commit to typetools/checker-framework that referenced this pull request Mar 11, 2020
@wmdietl
Add AssertionError(String, Throwable) annotations
93970b7 
Corresponding to typetools/jdk#28
@wmdietl wmdietl mentioned this pull request Mar 11, 2020
Merged
@wmdietl
Copy link
Copy Markdown
Member

wmdietl commented Mar 11, 2020

Thanks for the PR and sorry that nobody noticed it for so long.
I opened a corresponding CF PR: typetools/checker-framework#3159

@eaftan
Copy link
Copy Markdown
Author

eaftan commented Mar 11, 2020

No worries, thanks @wmdietl! For my information, what is the difference between this annotated JDK and the one in typetools/checker-framework?

@wmdietl
Copy link
Copy Markdown
Member

wmdietl commented Mar 12, 2020

No worries, thanks @wmdietl! For my information, what is the difference between this annotated JDK and the one in typetools/checker-framework?

This repository contains annotations for multiple type systems, is parsed as stub files at runtime, and is used on Java 9+ JVMs.

The one in typetools/checker-framework is split-up by type system, is compiled into the annotated JDK jdk8.jar file, and is used on the Java 8 compilation bootclasspath.
We're working on deprecating that version and only using typetools/jdk.

Also see https://github.com/typetools/checker-framework/blob/master/checker/jdk/README

wmdietl added a commit to typetools/checker-framework that referenced this pull request Mar 12, 2020
@wmdietl
Add AssertionError(String, Throwable) annotations (#3159)
c50f036 
Corresponding to typetools/jdk#28
@wmdietl wmdietl merged commit 1d0ed02 into typetools:master Mar 12, 2020
@wmdietl
Copy link
Copy Markdown
Member

wmdietl commented Mar 12, 2020

Thanks again. You can delete your branch now, if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eaftan @wmdietl