feat: update TypeScript to 5.0 RC by sosukesuzuki · Pull Request #6570 · typescript-eslint/typescript-eslint

sosukesuzuki · 2023-03-05T05:45:10Z

PR Checklist

Addresses an existing open issue: address TypeScript 5.0 Support #6380
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Updates typescript to 5.0.1-rc! Please see commits for details.

Todo

Fix tests for eslint-plugin
Fix type error for website source code

nx-cloud · 2023-03-05T05:45:12Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 43ae7de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2023-03-05T05:45:13Z

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2023-03-05T05:45:15Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`43ae7de`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/640cae80c543190008f38c31
😎 Deploy Preview	https://deploy-preview-6570--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sosukesuzuki · 2023-03-05T08:07:28Z

    function fakeUnknownKind(node: ts.Node): void {
      ts.forEachChild(node, fakeUnknownKind);
      // @ts-expect-error -- intentionally writing to a readonly field
+      // eslint-disable-next-line deprecation/deprecation


Should we use other node for testing?

codecov · 2023-03-05T15:15:05Z

Codecov Report

Merging #6570 (43ae7de) into main (9427b7c) will decrease coverage by 2.04%.
The diff coverage is 84.09%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6570      +/-   ##
==========================================
- Coverage   90.66%   88.62%   -2.04%     
==========================================
  Files         376      382       +6     
  Lines       12851    12883      +32     
  Branches     3783     3787       +4     
==========================================
- Hits        11651    11418     -233     
- Misses        856     1124     +268     
+ Partials      344      341       -3

Flag	Coverage Δ
unittest	`88.62% <84.09%> (-2.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/scope-manager/src/lib/dom.iterable.ts	`100.00% <ø> (ø)`
packages/scope-manager/src/lib/dom.ts	`100.00% <ø> (ø)`
...s/scope-manager/src/lib/es2015.symbol.wellknown.ts	`100.00% <ø> (ø)`
packages/scope-manager/src/lib/webworker.ts	`100.00% <ø> (ø)`
packages/type-utils/src/typeFlagUtils.ts	`75.00% <ø> (ø)`
packages/typescript-estree/src/convert.ts	`84.89% <ø> (ø)`
...-estree/src/create-program/createDefaultProgram.ts	`78.26% <ø> (ø)`
.../src/create-program/getWatchProgramsForProjects.ts	`79.08% <ø> (ø)`
packages/typescript-estree/src/getModifiers.ts	`58.33% <0.00%> (-2.54%)`	⬇️
packages/typescript-estree/src/version-check.ts	`100.00% <ø> (ø)`
... and 13 more

... and 4 files with indirect coverage changes

sosukesuzuki · 2023-03-05T16:01:22Z

      jsx,
      parseTSConfig(tsconfig).compilerOptions,
    );
+    // @ts-expect-error Monaco typescript.CompilerOptions is incompatible with typescript 5.0 types


We can remove this when Monaco updates CompilerOptions type

Out of curiousity, what's incompatible here? I'm trying to get monaco up to date among other things, so I'm curious.

Monaco has to redeclare everything for their public API, so, it's likely that this happens a lot and casing this away forever might be better (unless the problem is trivial).

Without @ts-expect-error, TS output the error Type 'ModuleResolutionKind.Classic' is not assignable to type 'ModuleResolutionKind | undefined'.

jakebailey · 2023-03-06T16:53:29Z

    "tslint": "^6.1.3",
    "tsx": "^3.12.1",
-    "typescript": ">=3.3.1 <5.0.0"
+    "typescript": ">=3.3.1 <4.9.5 || 5.0.1-rc"


Is there a reason to be so strict here? If we release 4.9.6 (however unlikely), that'll cause problems. That and I see basically no future in which we change the APIs post-RC, so it feels pretty safe to just bump this to < 5.1.0.

Though, I also think that you shouldn't specify versions here at all; given ts-eslint prints a very loud warning about using a potentially incompatible TypeScript version, this particular bit IMO only causes pain when trying to get package managers happy in the TypeScript repo or when testing newer releases of TypeScript in other repos...

This is the private package.json for our repo, and is not published to the outside world.
Each package that actually depends on TS uses an optional, unbounded peer dependency on TS:

typescript-eslint/packages/eslint-plugin/package.json

Lines 78 to 82 in a249412

"peerDependenciesMeta": {

"typescript": {

"optional": true

}

},

This range here is primarily here as our "top level" range to clearly specify the range for the project. At some point we want to automatically flow this value into our docs and package as the single point-of-definition.
It actually doesn't even do anything technically because just below it we have a resolution which forces a specific version of TS (eg this PR sets it to ~5.0.1-rc).

I agree though that we should probably keep it as <5.0.0 instead of dropping it down to <4.9.5

Ah, yes, oops. I'm conflating this with the fact that prereleases in the tree don't satisfy "*" or "latest" and cause duplication (boo).

bradzacher · 2023-03-06T23:40:11Z

+    if (typeof type.value === 'object') {
+      // Print ts.PseudoBigInt
+      return `${
+        type.value.negative ? '-' : ''
+      }${type.value.base10Value.toString()}n`;
+    }
    return type.value.toString();


This should be handled instead by the condition on line 111
We should move that branch up instaed

bradzacher

this is looking good to me!
I think we can merge this once we have the syntax changes ready

frank-weindel · 2023-03-16T16:53:37Z

@sosukesuzuki In my project, I've upgraded to @typescript-eslint/eslint-plugin@5.55.0 and @typescript-eslint/parser@5.55.0 which I understand has this change. My project is also using typescript@5.0.1-rc and using the new verbatimModuleSyntax compiler option. Eslint is giving me is errors at the top of every file it's checking:

0:0  error  Parsing error: Unknown compiler option 'verbatimModuleSyntax'

Is this a bug or do I simply not having something configured correctly?

jakebailey · 2023-03-16T17:26:09Z

Semver matching of preleases basically doesn't happen; to use a prerelease you would need to add an "overrides" section to your package.json.

That being said, TS 5.0 was just released, so the best answer will be to get ts-eslint's version change to allow the real deal.

Sosuke Suzuki added 11 commits March 5, 2023 12:36

feat: update to typescript 5.0

264d495

chore: update patch files

033d6a9

chore: update api-extractor

5e6fe24

chore: update downlevel-dts

c7ab394

chore(typescript-estree): use @ts-ignore for removed properties

70f47a4

chore(type-utils): use @ts-ignore comment for invalid enum assignment

6188c1a

test(typescript-estree): update snapshots for convert.test.ts

de114a5

feat(typescript-estree): add 5.0.0-rc to supported version

db61916

feat(typescript-estree): set experimentalDecorators: true

1a2f0cd

feat(scope-manager): run generate:lib

7e7c143

feat(types): run generate:lib

ced41d2

sosukesuzuki commented Mar 5, 2023

View reviewed changes

Comment thread packages/typescript-estree/src/create-program/createIsolatedProgram.ts Outdated

Sosuke Suzuki added 2 commits March 5, 2023 16:31

chore: fixes linting problems

f9d0594

chore: use ts.identifierToKeywordKind instead of originalKeywordKind

d022d8e

sosukesuzuki commented Mar 5, 2023

View reviewed changes

sosukesuzuki mentioned this pull request Mar 5, 2023

Enhancement: add experimentalDecorators option to typescript-estree #6571

Closed

4 tasks

sosukesuzuki force-pushed the update-to-ts-5.0 branch from c9be94f to d53c67c Compare March 5, 2023 15:00

fix(eslint-plugin): fix printing BigInt literal

49e64cb

sosukesuzuki force-pushed the update-to-ts-5.0 branch from d53c67c to 49e64cb Compare March 5, 2023 15:52

chore(website): add @ts-expect-error for imcompatible types

ef5475f

sosukesuzuki commented Mar 5, 2023

View reviewed changes

feat(typescript-estree): disable experimentalDecorators

1210fec

bradzacher reviewed Mar 6, 2023

View reviewed changes

chore: use @ts-expect-error instead of @ts-ignore

fc536c5

sosukesuzuki marked this pull request as ready for review March 6, 2023 13:21

jakebailey reviewed Mar 6, 2023

View reviewed changes

bradzacher reviewed Mar 6, 2023

View reviewed changes

chore(eslint-plugin): move the branch for printing BigInt literal

43ae7de

sosukesuzuki mentioned this pull request Mar 11, 2023

feat(typescript-estree): support const modifiers for type parameters #6600

Merged

4 tasks

bradzacher approved these changes Mar 13, 2023

View reviewed changes

bradzacher merged commit 36ef0e1 into typescript-eslint:main Mar 13, 2023

hasparus pushed a commit to hasparus/typescript-eslint that referenced this pull request Mar 22, 2023

feat: update TypeScript to 5.0 RC (typescript-eslint#6570)

30f9ef5

github-actions Bot locked as resolved and limited conversation to collaborators Mar 24, 2023

Uh oh!

Conversation

sosukesuzuki commented Mar 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Todo

Uh oh!

nx-cloud Bot commented Mar 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

typescript-eslint Bot commented Mar 5, 2023

Uh oh!

netlify Bot commented Mar 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Mar 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bradzacher Mar 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bradzacher left a comment

Choose a reason for hiding this comment

Uh oh!

frank-weindel commented Mar 16, 2023

Uh oh!

jakebailey commented Mar 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sosukesuzuki commented Mar 5, 2023 •

edited

Loading

nx-cloud Bot commented Mar 5, 2023 •

edited

Loading

netlify Bot commented Mar 5, 2023 •

edited

Loading

codecov Bot commented Mar 5, 2023 •

edited

Loading

bradzacher Mar 6, 2023 •

edited

Loading