fix(eslint-plugin): respect ECMAScript line terminators in ts-comment rules#12352
Merged
JoshuaKGoldberg merged 1 commit intoMay 27, 2026
Conversation
…Script line terminators
Contributor
|
Thanks for the PR, @lumirlumir! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 11018d4
☁️ Nx Cloud last updated this comment at |
ban-ts-comment and prefer-ts-expect-error don't respect ECMAScript line terminators
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12352 +/- ##
=======================================
Coverage 86.82% 86.82%
=======================================
Files 513 513
Lines 16494 16494
Branches 5141 5141
=======================================
Hits 14321 14321
Misses 1478 1478
Partials 695 695
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Closed
4 tasks
JoshuaKGoldberg
approved these changes
May 22, 2026
JoshuaKGoldberg
left a comment
Member
There was a problem hiding this comment.
LGTM once you think it's ready! 🥇
Contributor
Author
|
Thanks for the quick review! It’s all ready now :) |
3 tasks
1ab4284
into
typescript-eslint:main
76 of 77 checks passed
This was referenced May 28, 2026
1 task
renovate Bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jun 7, 2026
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.60.0 | 8.60.1 | | npm | @typescript-eslint/parser | 8.60.0 | 8.60.1 | ## [v8.60.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8601-2026-06-01) ##### 🩹 Fixes - **eslint-plugin:** \[no-shadow] correct rule to match ESLint v10 handling ([#12182](typescript-eslint/typescript-eslint#12182)) - **eslint-plugin:** respect ECMAScript line terminators in ts-comment rules ([#12352](typescript-eslint/typescript-eslint#12352)) ##### ❤️ Thank You - lumir - Nevette Bailey [@nevette-bailey](https://github.com/nevette-bailey) See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.60.1) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovate Bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jun 12, 2026
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.60.0 | 8.61.0 | | npm | @typescript-eslint/parser | 8.60.0 | 8.61.0 | ## [v8.61.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8610-2026-06-08) ##### 🚀 Features - **ast-spec:** change type of `UnaryExpression.prefix` to always `true` ([#12372](typescript-eslint/typescript-eslint#12372)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.61.0) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website. ## [v8.60.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8601-2026-06-01) ##### 🩹 Fixes - **eslint-plugin:** \[no-shadow] correct rule to match ESLint v10 handling ([#12182](typescript-eslint/typescript-eslint#12182)) - **eslint-plugin:** respect ECMAScript line terminators in ts-comment rules ([#12352](typescript-eslint/typescript-eslint#12352)) ##### ❤️ Thank You - lumir - Nevette Bailey [@nevette-bailey](https://github.com/nevette-bailey) See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.60.1) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
ban-ts-commentandprefer-ts-expect-errordon't respect ECMAScript line terminators #12353Overview
This PR fixes an issue mentioned in #12353.
😄