Skip to content

test: fix jest plugin usage in integration test#10328

Merged
JoshuaKGoldberg merged 2 commits into
typescript-eslint:mainfrom
yeonjuan:fix-failing-ci
Nov 14, 2024
Merged

test: fix jest plugin usage in integration test#10328
JoshuaKGoldberg merged 2 commits into
typescript-eslint:mainfrom
yeonjuan:fix-failing-ci

Conversation

@yeonjuan

@yeonjuan yeonjuan commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

PR Checklist

Overview

@typescript-eslint

typescript-eslint Bot commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify

netlify Bot commented Nov 13, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1ff57b7
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/673622d6a63a5300084baf5e
😎 Deploy Preview https://deploy-preview-10328--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud

nx-cloud Bot commented Nov 13, 2024 •
edited
Loading

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1ff57b7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Nov 14, 2024
View reviewed changes

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captain Hook from Hook (1991) saying "KILL THEM" "KILL THEM ALL"

Comment thread packages/integration-tests/fixtures/flat-config-types-@types__eslint-v8/eslint.config.js Outdated
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 14, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 14, 2024
View reviewed changes

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cartoon penguin with a shine and sparkle animation

@JoshuaKGoldberg JoshuaKGoldberg added 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting response Issues waiting for a reply from the OP or another party labels Nov 14, 2024
@JoshuaKGoldberg

JoshuaKGoldberg commented Nov 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Merging quickly to get the repo fixed up. Thanks as always!

@JoshuaKGoldberg JoshuaKGoldberg merged commit a596501 into typescript-eslint:main Nov 14, 2024
omril1 pushed a commit to omril1/typescript-eslint that referenced this pull request Nov 16, 2024
@yeonjuan
test: fix jest plugin usage in integration test (typescript-eslint#10328
e4fad3b 
)

* test: fix jest plugin usage in integration test

* fixup
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 16, 2024
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repo: Failing integration tests for primary Nodejs version on main

2 participants

@yeonjuan @JoshuaKGoldberg