Skip to content

fix: findRoots should get the defined primary key column #6982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pleerock merged 2 commits into from
Oct 30, 2020
Merged

fix: findRoots should get the defined primary key column #6982

pleerock merged 2 commits into from
Oct 30, 2020

Conversation

@ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented Oct 28, 2020 •
edited
Loading

Description of change

Previously findRoots assumes the primary column of an entity to be named id

typeorm/src/repository/TreeRepository.ts

Lines 35 to 37 in a5eb946

const parentPropertyName = this.manager.connection.namingStrategy.joinColumnName(
this.metadata.treeParentRelation!.propertyName, "id"
);

This PR will instead use the column defined by entity class

Fixes #6948, #2361

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames added the hacktoberfest-accepted label hacktoberfest label Oct 29, 2020
@pleerock pleerock merged commit f2ba901 into typeorm:master Oct 30, 2020
@pleerock
Copy link
Member

pleerock commented Oct 30, 2020

Thank you!

dolsup pushed a commit to dolsup/typeorm that referenced this pull request Nov 3, 2020
@ilyasfoo @dolsup
fix: findRoots should get the defined primary key column (typeorm#6982)
fbe8ad0 
* test: added failing test for github issue typeorm#6948

* fix: findRoots should get the actual primary key column, fixes typeorm#6948
@mateussilva92 mateussilva92 mentioned this pull request Dec 7, 2020
Closed
zaro pushed a commit to zaro/typeorm that referenced this pull request Jan 12, 2021
@ilyasfoo
fix: findRoots should get the defined primary key column (typeorm#6982)
52ff7a0 
* test: added failing test for github issue typeorm#6948

* fix: findRoots should get the actual primary key column, fixes typeorm#6948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

hacktoberfest-accepted label hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TreeRepository's findRoots query incorrectly when using a custom primary key

3 participants

@ilyasfoo @pleerock @imnotjames