Skip to content

refactor: export LoggerOptions interface #6976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pleerock merged 1 commit into from
Oct 26, 2020
Merged

refactor: export LoggerOptions interface #6976

pleerock merged 1 commit into from
Oct 26, 2020

Conversation

@pkuczynski
Copy link
Collaborator

@pkuczynski pkuczynski commented Oct 26, 2020

Description of change

Export LoggerOptions, which allows developers to properly type their own variables (eg. configurations).

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000 N/A
  • There are new or updated unit tests validating the change N/A
  • Documentation has been updated to reflect this change N/A
  • The new commits follow conventions explained in [CONTRIBUTING.md] (https://github.com/typeorm/typeorm/blob/master/CONTRIBUTING.md)

@pkuczynski pkuczynski changed the title Export LoggerOptions interface refactor: export LoggerOptions interface Oct 26, 2020
@pleerock pleerock merged commit fa86413 into typeorm:master Oct 26, 2020
@pkuczynski
Copy link
Collaborator Author

pkuczynski commented Oct 26, 2020

@pleerock thanks for quick merge! When do you think it will get released?

@pkuczynski pkuczynski deleted the patch-1 branch October 26, 2020 12:51
@pleerock
Copy link
Member

pleerock commented Oct 26, 2020

thanks @pkuczynski ! hope to make a new release this week!

@imnotjames imnotjames added the hacktoberfest-accepted label hacktoberfest label Oct 26, 2020
dolsup pushed a commit to dolsup/typeorm that referenced this pull request Nov 3, 2020
@pkuczynski @dolsup
refactor: export LoggerOptions interface (typeorm#6976)
254391d
zaro pushed a commit to zaro/typeorm that referenced this pull request Jan 12, 2021
@pkuczynski
refactor: export LoggerOptions interface (typeorm#6976)
72322ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

hacktoberfest-accepted label hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkuczynski @pleerock @imnotjames