fix: explicitly define query command's param
#6899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the CLI command `query` had an implicit `query` positional parameter and in earlier versions of yargs that was okay - but in the later versions aiming for more correct code they've refactored it to not support that explicitly define the `query` positional parameter & add a helpful description so people can tell what it is for fixes typeorm#6896
a7214b2 to
66a21ec
Compare
7 tasks
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
the CLI command `query` had an implicit `query` positional parameter and in earlier versions of yargs that was okay - but in the later versions aiming for more correct code they've refactored it to not support that explicitly define the `query` positional parameter & add a helpful description so people can tell what it is for fixes typeorm#6896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the CLI command
queryhad an implicitquerypositionalparameter and in earlier versions of yargs that was okay -
but in the later versions aiming for more correct code they've
refactored it to not support that
explicitly define the
querypositional parameter & add ahelpful description so people can tell what it is for
fixes #6896