Skip to content

feat(RelationDecorators): allow to pass string instead of typeFunction #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pleerock merged 1 commit into from
May 30, 2019
Merged

feat(RelationDecorators): allow to pass string instead of typeFunction #4195

pleerock merged 1 commit into from
May 30, 2019

Conversation

@haschu
Copy link
Contributor

@haschu haschu commented May 26, 2019

Closes #4190

In addition to

@OneToOne(type => Profile)
@ManyToOne(type => User, user => user.photos)
@ManyToMany(type => Category)

now it's also possible to write:

@OneToOne('Profile')
@ManyToOne('User','photos')
@ManyToMany('Category')

Using this approach can prevent circular dependency issues when TypeORM is used within a frontend/browser application (e.g. when running through Angular CLI).

@haschu
Copy link
Contributor Author

haschu commented May 26, 2019 •
edited
Loading

Cool, tests failed for Node.js 9! I'm not sure if that's related to my changes... Error in before each, can anybody restart it?

Edit: So I ran the tests locally on Node v9.11.2 and they passed :/

@rustamwin rustamwin requested a review from pleerock May 28, 2019 12:18
@pleerock
Copy link
Member

pleerock commented May 30, 2019

Thanks, it's a good change. We should have it much earlier.

@pleerock pleerock merged commit 56547ba into typeorm:master May 30, 2019
@pleerock
Copy link
Member

pleerock commented May 30, 2019

Oh, we should make a change in a changelog .

@rustamwin rustamwin removed the request for review from pleerock May 30, 2019 05:28
@haschu
Copy link
Contributor Author

haschu commented May 30, 2019

Argh... sorry, I overlooked the changelog part in CONTRIBUTING.md - going to submit a PR to fix that soon.

I also realized, that typeorm-class-transformer-shim.js wouldn't work with the "string instead of typeFunction" approach. I'm also trying to fix that soon.

@pleerock Thank you so much for the fast merge - I have noticed that you're struggling at the moment to find enough time for TypeORM. I really appreciate it, as my team is migrating our in-house framework to TypeORM and we were stuck at this point. And also thanks for your effort to bring up such an amazing project! :)

@haschu haschu deleted the feat/4190 branch May 30, 2019 08:08
haschu added a commit to haschu/typeorm that referenced this pull request May 30, 2019
@haschu
fix(changelog): Added missing line for PR typeorm#4195
c89c40f
@haschu haschu mentioned this pull request May 30, 2019
Merged
pleerock added a commit that referenced this pull request May 30, 2019
@pleerock
Merge pull request #4211 from haschu/fix/4190-changelog
5522acb 
fix(changelog): Added missing line for PR #4195
@haschu haschu mentioned this pull request May 30, 2019
Closed
@mnzaki mnzaki mentioned this pull request Aug 16, 2019
Merged
@ghiobi ghiobi mentioned this pull request Oct 19, 2020
Merged
@forivall forivall mentioned this pull request Mar 4, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Relation decorators: allow to pass string instead of typeFunction

2 participants

@haschu @pleerock