Skip to content

Conversation

@alumni
Copy link
Collaborator

@alumni alumni commented Nov 28, 2025

Description of change

Update all TypeORM and documentation dependencies.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • This pull request links relevant issues as Fixes #00000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change

@qodo-free-for-open-source-projects

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Import Type Change

The import for LLMsTXTPluginOptions changed from a value import to a type-only import (PluginOptions as LLMsTXTPluginOptions). Verify that this type is only used for type annotations and not as a runtime value, otherwise this could cause runtime errors.

import { PluginOptions as LLMsTXTPluginOptions } from "@signalwire/docusaurus-plugin-llms-txt"
import { themes as prismThemes } from "prism-react-renderer"
Breaking Version Updates

Multiple major version updates for database drivers (@google-cloud/spanner from ^7 to ^8, mssql from ^11 to ^12) and the Node.js engine requirement increased from >=18.0 to >=20.0 in docs. These breaking changes should be tested thoroughly across all supported database platforms to ensure compatibility.

"@google-cloud/spanner": "^5.18.0 || ^6.0.0 || ^7.0.0 || ^8.0.0",
"@sap/hana-client": "^2.14.22",
"better-sqlite3": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0",
"ioredis": "^5.0.4",
"mongodb": "^5.8.0 || ^6.0.0",
"mssql": "^9.1.1 || ^10.0.0 || ^11.0.0 || ^12.0.0",
Configuration Removal

The onBrokenMarkdownLinks: "warn" configuration was removed. This changes error handling behavior for broken markdown links from warnings to the default behavior. Verify this is intentional and won't hide important documentation issues.

onBrokenLinks: "throw",

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 28, 2025

typeorm-sql-js-example

npm i https://pkg.pr.new/typeorm/typeorm@11811

commit: 94b2b76

@qodo-free-for-open-source-projects

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Use standard engines field for version enforcement

Replace the non-standard devEngines field with the standard engines field in
package.json to enforce development environment versions correctly.

package.json [248-258]

-"devEngines": {
-  "runtime": {
-    "name": "node",
-    "version": ">=20.19.0"
-  },
-  "packageManager": {
-    "name": "npm",
-    "version": "^10.8.2",
-    "onFail": "error"
-  }
+"engines": {
+  "node": ">=20.19.0",
+  "npm": ">=10.8.2"
 },
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies that devEngines is a non-standard field and recommends using the standard engines field, which improves compatibility with package managers and project maintainability.

Low
  • More

Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊 thanks for this @alumni

@gioboa gioboa merged commit 5461927 into typeorm:master Nov 29, 2025
95 of 97 checks passed
@alumni
Copy link
Collaborator Author

alumni commented Nov 29, 2025

@gioboa thanks for the approval, I forgot to update the PR description 🤭

Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem at all @alumni

ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
mgohin pushed a commit to mgohin/typeorm that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants