Walkthrough

Comprehensive modernization PR updating Node.js support (>=20.9.0 or >=22.11.0), migrating from rimraf/glob to native fs.rm/tinyglobby, adding AsyncDisposable support to query runners, updating TypeScript targets to ES2023, refactoring ESLint and Prettier configs, and reformatting code across drivers and tests for consistency.

Changes

Sequence Diagram(s)

sequenceDiagram
    actor Code as Application Code
    participant QR as QueryRunner<br/>(AsyncDisposable)
    participant DB as Database
    participant Pool as Connection Pool

    rect rgba(100, 200, 100, 0.2)
    Note over Code,Pool: using block acquisition
    Code->>QR: createQueryRunner()
    QR->>Pool: acquire connection
    Pool-->>QR: connection
    end

    rect rgba(100, 150, 200, 0.2)
    Note over Code,Pool: execute operations
    Code->>QR: executeQuery()
    QR->>DB: query
    DB-->>QR: result
    Code->>QR: commitTransaction()
    QR->>DB: COMMIT
    DB-->>QR: ok
    end

    rect rgba(200, 100, 100, 0.2)
    Note over Code,QR: scope exit (using end)
    Code->>QR: [Symbol.asyncDispose]()
    QR->>QR: release()
    QR->>Pool: return connection
    Pool-->>QR: released
    QR-->>Code: Promise<void>
    end

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Areas requiring extra attention:

• package.json engine constraints & dependency bumps — Verify Node 20.9.0 and 22.11.0 compatibility across all downstream tooling; review peerDependencies against ecosystem constraints
• AsyncDisposable interface implementation — Ensure QueryRunner subclasses properly override release() and commitTransaction(); validate using statement behavior in test/functional/query-runner/async-dispose.ts
• ESLint config structural change (globalIgnores replacement) — Confirm new flat config format functions correctly with defineConfig and test runner integrations
• Driver class declare keyword changes — Multiple driver files converted properties to ambient declarations; verify no runtime errors or missing initialization paths in subclasses
• glob → tinyglobby migration — Check DirectoryExportedClassesLoader.ts and test file migrations for correctness of globSync API calls and behavior parity
• Ternary → if/else refactoring in driver error handlers — Verify all error handling branches (fail/ok) match original ternary semantics across aurora-mysql, cockroachdb, mysql, postgres, oracle drivers
• GitHub workflow node-version matrices — Confirm CockroachDB condition (>=22) and test matrix alignment (20, 24) do not break CI/CD

Possibly related PRs

• feat!: drop support for node 16 and 18 #11382 — Both PRs update Node.js version support requirements (dropping Node 16, updating to 20+/22+), modify TypeScript targets to ES2023, and adjust GitHub workflows and package.json engine constraints.
• chore: update dependencies #11666 — Both PRs modify package.json dependency/devDependency versions and structure, updating tooling compatibility across the ecosystem.
• ci: control development and CI version of Node.js via .nvmrc #11708 — Both PRs adjust GitHub workflow node-version configuration; the related PR explores .nvmrc-based workflow updates while this PR uses explicit version matrices.

Suggested reviewers

• alumni
• sgarner
• mguida22
• OSA413
• michaelbromley

Poem

🐰 A hop through Node's greener lands,
From ancient eighteen to twenty-two so grand,
With declare keywords, AsyncDispose in hand,
No rimraf, no glob—tinyglobby commands,
Formatting polish, configs refined—
TypeORM's future, modernized and aligned! ✨

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

} catch {
    throw new DriverPackageNotInstalledError("Oracle", "oracledb")

typeorm-sql-js-example

npm i https://pkg.pr.new/typeorm/typeorm@11787

commit: a85e164

PR Code Suggestions ✨

Explore these optional code suggestions:

-      node-version: 222
+      node-version: 22

-node-version: 222
+node-version: 22

+protected loadDependencies(): void {
+    try {
+        const oracle = this.options.driver || PlatformTools.load("oracledb")
+        this.oracle = oracle
+    } catch (e) {
+        throw new DriverPackageNotInstalledError("Oracle", "oracledb")
+    }
+    const thickMode = this.options.thickMode
+    if (thickMode) {
+        if (typeof thickMode === "object") {
+            this.oracle.initOracleClient(thickMode)
+        } else {
+            this.oracle.initOracleClient()
+        }
+    }
+}
 
-

 it("should commit the transaction in progress", () =>
     Promise.all(
         dataSources.map(async (dataSource) => {
             let releaseSpy: sinon.SinonSpy | null = null
             let error: Error | null = null
 
             async function insertEmployee() {
                 await using queryRunner = dataSource.createQueryRunner()
                 releaseSpy = sinon.spy(queryRunner, "release")
                 await queryRunner.startTransaction("READ UNCOMMITTED")
+                await queryRunner.manager.save(Company, {
+                    id: 100,
+                    name: "Acme",
+                })
                 await queryRunner.sql`INSERT INTO "employee"("name", "companyId") VALUES ('John Doe', 100)`
             }
 
             try {
                 await insertEmployee()
             } catch (e) {
                 error = e
             }
 
-            expect(error).to.be.instanceOf(QueryFailedError)
-            expect((error as QueryFailedError).query).to.equal("COMMIT")
+            expect(error).to.be.null
             expect(releaseSpy).to.have.been.calledOnce
         }),
     ))

-const { globSync } = require("node:fs")
+const { sync } = require("glob")
 const path = require("node:path")
 
 module.exports = {
     // ... your webpack configurations here...
     // Dynamically generate a `{ [name]: sourceFileName }` map for the `entry` option
     // change `src/db/migrations` to the relative path to your migration folder
-    entry: globSync(path.resolve("src/db/migrations/*.ts")).reduce(
+    entry: sync(path.resolve("src/db/migrations/*.ts")).reduce(
         (entries, filename) => {
             const migrationName = path.basename(filename, ".ts")
             return Object.assign({}, entries, {
                 [migrationName]: filename,
             })
         },
         {},
     ),

Deploying typeorm with    Cloudflare Pages

View logs

@pkuczynski For some reason the cli init command is installing the old version of typeorm which has peerDependencies: { mssql: "^9 || ^10 || ^11" }}, but in the next branch we only work with mssql@12.

So the question is: how did it work in the past? and why is it installing typeorm@0.3.27?

Later edit: