• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch task/update-dependencies

Reviewing files that changed from the base of the PR and between 797a8f5 and a6f2115.

• docs/package-lock.json is excluded by !**/package-lock.json
• package-lock.json is excluded by !**/package-lock.json
• sample/playground/package-lock.json is excluded by !**/package-lock.json

• .gitignore (0 hunks)
• docs/package.json (2 hunks)
• package.json (2 hunks)
• sample/playground/package.json (1 hunks)
• src/driver/sqlserver/SqlServerQueryRunner.ts (1 hunks)
• test/functional/columns/virtual-columns/virtual-columns.ts (1 hunks)
• test/functional/driver/abstract-sqlite/abstract-sqlite-escape-query-parameters.ts (2 hunks)
• test/github-issues/9189/issue-9189.ts (1 hunks)
• test/utils/test-utils.ts (1 hunks)

• .gitignore

• GitHub Check: tests-linux (20) / sqljs
• GitHub Check: tests-linux (20) / mssql
• GitHub Check: tests-linux (20) / mysql_mariadb_latest
• GitHub Check: tests-linux (20) / better-sqlite3
• GitHub Check: tests-linux (18) / sap
• GitHub Check: tests-linux (20) / mongodb
• GitHub Check: tests-linux (20) / cockroachdb
• GitHub Check: tests-linux (18) / oracle

sample/playground/package.json (1)

17-17: LGTM! Dependency updates align with repository-wide version standardization.

The updates to @types/node (^20.19.0 → ^22.18.6) and typescript (^5.8.3 → ^5.9.2) are consistent with the broader PR's dependency management goals and the removal of reflect-metadata from this package.json aligns with it being moved to the root dependencies.

Also applies to: 19-19

docs/package.json (1)

33-33: LGTM! Minor version updates are appropriate.

The updates to @mdx-js/react (^3.1.0 → ^3.1.1) and typescript (~5.8.3 → ~5.9.2) are consistent with the repository-wide TypeScript upgrade pattern seen across the PR.

Also applies to: 45-45

src/driver/sqlserver/SqlServerQueryRunner.ts (1)

2720-2720: LGTM! Async callback correctly handles Promise return values.

The change from allTablesResults.map((tablesResult) => { to allTablesResults.map(async (tablesResult) => { is correct since the callback now needs to handle the return this.query(dropTableSql) which returns a Promise. This ensures proper async handling within the Promise.all context.

test/functional/driver/abstract-sqlite/abstract-sqlite-escape-query-parameters.ts (2)

1-1: LGTM! Adding chai import for expect assertions.

The addition of expect from chai is necessary for the updated assertion style used throughout the test file.

---

22-30: LGTM! Refactored assertions improve test clarity.

The changes from Promise.all(connections.map(...)) to connections.map(...) and from should-style assertions to expect(...).to.deep.equal(...) are appropriate improvements:

1. Since escapeQueryWithParameters is synchronous, removing the Promise.all wrapper is correct
2. The chai expect syntax with deep.equal is more explicit and readable than should-style assertions
3. The expected parameter transformations ([1], [0], [1], [0]) correctly verify boolean to integer conversion

Also applies to: 32-41, 43-52, 54-63

package.json (2)

115-168: LGTM! DevDependency updates follow appropriate version constraints.

The devDependency updates are substantial but follow semantic versioning appropriately. Notable updates include:

• TypeScript 5.8.3 → 5.9.2 (minor version, should be backward compatible)
• MongoDB driver 6.15.0 → 6.20.0 (compatible with the existing peer dependency range)
• Mocha 10.8.2 → 11.7.2 (major version, but test frameworks often have fewer breaking changes)

The type definition downgrades (e.g., @types/sinon-chai 4.0.0 → 3.2.12) suggest alignment with actual package versions being used.

---

99-107: Approve dependency changes — ansis v4 and reflect-metadata move are safe.

• ansis: imported in PlatformTools and command files (PlatformTools.ts, SchemaLogCommand.ts, SchemaSyncCommand.ts, MigrationGenerateCommand.ts, MigrationCreateCommand.ts, InitCommand.ts, EntityCreateCommand.ts, QueryCommand.ts, CacheClearCommand.ts, SchemaDropCommand.ts, SubscriberCreateCommand.ts). Usages (underline, gray, red, yellow, blue, white, green, tagged-template usage) do not use removed/renamed aliases (.strike, .grey, .ansi256, .blackBright, .bgGrey, .bgBlackBright).
• reflect-metadata: present in dependencies ("^0.2.2" in package.json) and imported by src/index.ts and src/cli.ts — keeping it as a dependency is correct.

test/utils/test-utils.ts (2)

487-499: LGTM! Async function signature improves error handling.

Converting closeTestingConnections to async with proper Promise.all usage ensures that all connection closures are properly awaited and any errors are properly propagated. The optional chaining (connection?.isInitialized) is a good defensive programming practice.

---

504-509: LGTM! Async function signature maintains proper sequencing.

Converting reloadTestingDatabases to async ensures that all database synchronizations complete before the function returns. The await Promise.all() preserves concurrent execution while ensuring proper error propagation.

test/github-issues/9189/issue-9189.ts (1)

17-22: LGTM! Simplified async assignment pattern.

The change from wrapping createTestingConnections in Promise.all to direct assignment is correct since createTestingConnections already returns a Promise<DataSource[]>. This simplification improves code readability while maintaining the same functional behavior.

test/functional/columns/virtual-columns/virtual-columns.ts (1)

70-71: Verify that the refactored connection mapping maintains test correctness.

The change from Promise.all(connections.map(async (connection) => { ... })) to connections.map((connection) => { ... }) removes the asynchronous aggregation. Since these tests are performing synchronous SQL generation and assertions (via getSql()), this change is functionally correct. However, it's important to verify that removing the Promise.all wrapper doesn't affect test execution behavior.

Also applies to: 91-92, 125-126