-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs: fix broken migration links #11760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix broken migration links #11760
Conversation
WalkthroughUpdated documentation links and redirect targets to consolidate migrations paths to Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer (PR)
participant GH as GitHub Actions
participant Repo as Repository
Dev->>Repo: Push PR with docs changes
note right of Repo `#DDEEFF`: Previously docs/** ignored\nby pull_request paths-ignore
Repo->>GH: Evaluate pull_request triggers
GH->>GH: Match triggers (docs/** no longer ignored)
GH->>GH: Run commit-validation workflow
GH-->>Dev: Report CI results
sequenceDiagram
autonumber
participant User as Client Request
participant Site as Docs Site Router
User->>Site: GET /migrations
Site->>Site: Lookup redirects
note right of Site `#E8F5E9`: Updated mapping -> /docs/migrations/why
Site-->>User: 301 Redirect to /docs/migrations/why
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gioboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mguida22
It looks good to me 👏
|
huh it looks like CI is stuck. the jobs have run in my fork but not here (or at least not reported here). |
|
Looks like checks aren't configured to run on docs only changes typeorm/.github/workflows/commit-validation.yml Lines 1 to 13 in 51fbcf4
|
#11761 should solve that issue. But now it fails, as it's missing fixes from this PR :) @michaelbromley maybe we should lift the build-pass requirement for the moment? |
| paths-ignore: | ||
| - "docs/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is removed in this PR so CI runs on this change which is docs only.
#11761 will update the workflow so it correctly decides which jobs to run on docs only changes
Description of change
Fixes a few redirects and links to the new migration section.
This is currently causing docs builds to fail CI and preventing the changes in #11674 from being deployed.
Pull-Request Checklist
masterbranchFixes #00000Summary by CodeRabbit
Documentation
Chores