Skip to content

lint: fix offenses for @typescript-eslint/no-unused-vars rule in tests folder #11755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelbromley merged 7 commits into from
Nov 9, 2025
Merged

lint: fix offenses for @typescript-eslint/no-unused-vars rule in tests folder #11755

michaelbromley merged 7 commits into from
Nov 9, 2025
+310 −335

Conversation

@pkuczynski
Copy link
Collaborator

@pkuczynski pkuczynski commented Nov 9, 2025 •
edited
Loading

Description of change

No functional changes. Fixes @typescript-eslint/no-unused-vars in the tests folder. I will fix code in separate PR.

Gets the offence count down from 784 to 475 for this rule.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • This pull request links relevant issues as Fixes #00000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change

@pkuczynski pkuczynski self-assigned this Nov 9, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 9, 2025 •
edited
Loading

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

109 files out of 216 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

gioboa
gioboa approved these changes Nov 9, 2025
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👏

@pkuczynski pkuczynski requested a review from naorpeled November 9, 2025 19:39
@pkuczynski pkuczynski mentioned this pull request Nov 9, 2025
Merged
4 tasks
@pkuczynski pkuczynski changed the title lint: fix offenses for @typescript-eslint/no-unused-vars rule lint: fix offenses for @typescript-eslint/no-unused-vars rule in tests folder Nov 9, 2025
@michaelbromley michaelbromley merged commit 08a9397 into typeorm:master Nov 9, 2025
60 checks passed
ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
@pkuczynski @ThbltLmr
lint: fix offenses for @typescript-eslint/no-unused-vars rule in test…
0dbe7a2 
…s folder (typeorm#11755)
mgohin pushed a commit to mgohin/typeorm that referenced this pull request Jan 15, 2026
@pkuczynski
lint: fix offenses for @typescript-eslint/no-unused-vars rule in test…
c2c55ec 
…s folder (typeorm#11755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelbromley michaelbromley michaelbromley approved these changes

@gioboa gioboa gioboa approved these changes

@naorpeled naorpeled Awaiting requested review from naorpeled

Assignees

@pkuczynski pkuczynski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkuczynski @michaelbromley @gioboa