Skip to content

feat: export QueryPartialEntity and QueryDeepPartialEntity types #11748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OSA413 merged 4 commits into from
Nov 23, 2025
Merged

feat: export QueryPartialEntity and QueryDeepPartialEntity types #11748

OSA413 merged 4 commits into from
Nov 23, 2025

Conversation

@danielsharvey
Copy link
Contributor

@danielsharvey danielsharvey commented Nov 3, 2025 •
edited by pkuczynski
Loading

Description of change

Add missing type exports. The types QueryPartialEntity and QueryDeepPartialEntity
are included in the codebase but missing from the package exports.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • This pull request links relevant issues as Fixes #00000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change

Summary by CodeRabbit

Release Notes

  • New Features
    • Expanded the public API with newly available types, enabling developers to leverage additional functionality for query-related operations and use cases.
ni

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025 •
edited
Loading

Walkthrough

Added public exports for QueryPartialEntity and QueryDeepPartialEntity types from the query-builder module to the main index file, expanding the library's public API surface without modifying existing behavior.

Changes

Cohort / File(s) Summary
Export Expansion
src/index.ts		 Added public exports for QueryPartialEntity and QueryDeepPartialEntity types from ./query-builder/QueryPartialEntity module

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Straightforward export additions with no behavioral changes
  • Limited scope affecting only the index file

Poem

🐰 Exports bloom like carrots in spring,
New types now visible, making code sing,
QueryPartial friends join the API feast,
A simple, delightful change, to say the least! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'Export QueryPartialEntity and QueryDeepPartialEntity' directly and accurately describes the main change in the changeset. The raw summary confirms that the only modification is adding public exports for these two types from the query-builder module to src/index.ts. The title is concise, clear, and specific enough that a reviewer scanning the history would immediately understand the primary purpose of this change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7867eb and dc38514.

📒 Files selected for processing (1)
  • src/index.ts (1 hunks)
🔇 Additional comments (1)
src/index.ts (1)

163-163: Export verified and correctly implemented.

Verification confirms that QueryPartialEntity and QueryDeepPartialEntity are properly defined in src/query-builder/QueryPartialEntity.ts and the export statement at line 163 is the only reference to these types in the codebase. No conflicts or duplicates exist.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gioboa gioboa requested review from G0maa and pkuczynski November 14, 2025 09:30
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 14, 2025 •
edited
Loading

typeorm-sql-js-example

npm i https://pkg.pr.new/typeorm/typeorm@11748

commit: a85bf5b

@pkuczynski pkuczynski changed the title Export QueryPartialEntity and QueryDeepPartialEntity feat: export QueryPartialEntity and QueryDeepPartialEntity types Nov 23, 2025
@pkuczynski
Copy link
Collaborator

pkuczynski commented Nov 23, 2025

@danielsharvey can you run code format? The test failure is not related to this change, we will fix it in a different PR soon

@OSA413 OSA413 merged commit ade198c into typeorm:master Nov 23, 2025
157 of 163 checks passed
gioboa
gioboa approved these changes Nov 23, 2025
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @danielsharvey

ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
@danielsharvey @gioboa
@pkuczynski @OSA413 @ThbltLmr
feat: export QueryPartialEntity and QueryDeepPartialEntity types (typ…
402287b 
…eorm#11748)

Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>
Co-authored-by: Piotr Kuczynski <piotr.kuczynski@gmail.com>
Co-authored-by: Oleg "OSA413" Sokolov <OSA413@users.noreply.github.com>
@Minishlink Minishlink mentioned this pull request Jan 12, 2026
Open
mgohin pushed a commit to mgohin/typeorm that referenced this pull request Jan 15, 2026
@danielsharvey @gioboa
@pkuczynski @OSA413
feat: export QueryPartialEntity and QueryDeepPartialEntity types (typ…
0a04cad 
…eorm#11748)

Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>
Co-authored-by: Piotr Kuczynski <piotr.kuczynski@gmail.com>
Co-authored-by: Oleg "OSA413" Sokolov <OSA413@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkuczynski pkuczynski pkuczynski approved these changes

@G0maa G0maa G0maa approved these changes

@OSA413 OSA413 OSA413 approved these changes

@gioboa gioboa gioboa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danielsharvey @pkuczynski @G0maa @OSA413 @gioboa