Skip to content

Conversation

@gioboa
Copy link
Collaborator

@gioboa gioboa commented Oct 3, 2025

Description of change

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • This pull request links relevant issues as Fixes #00000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change

Summary by CodeRabbit

  • New Features
    • No user-facing feature changes.
  • Chores
    • Upgraded GitHub Actions across CI to use actions/checkout v5.
    • Bumped actions/setup-node to v5 in commit validation workflows.
    • Applies to code scanning, docs indexing, preview builds, package publishing, and test pipelines.
    • Aims for improved reliability and security with no behavioral changes.
  • Tests
    • Updated Linux and Windows test matrices to use the latest checkout action across all jobs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

Walkthrough

Version bumps in GitHub Actions workflows: actions/checkout upgraded from v4 to v5 across multiple workflows; actions/setup-node upgraded to v5 only in commit-validation workflow. No other logic, triggers, or steps changed.

Changes

Cohort / File(s) Summary of changes
Checkout action v4 → v5
.github/workflows/codeql.yml, .github/workflows/docsearch.yml, .github/workflows/preview.yml, .github/workflows/publish-package.yml, .github/workflows/tests-linux.yml, .github/workflows/tests-windows.yml, .github/workflows/commit-validation.yml
Bump actions/checkout from v4 to v5 in listed workflows; no control-flow edits.
Node setup action v4 → v5 (where applicable)
.github/workflows/commit-validation.yml
Bump actions/setup-node to v5 in formatting and build jobs; other actions unchanged.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • naorpeled
  • alumni

Poem

A hop, a skip, a version lift—
I nudge the gears with gentle drift.
From four to five the checkouts go,
Node’s on five—we’re set to flow.
I twitch my ears, CI hums bright—
Release-bound paws, green lights at night. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly describes the primary change in CI workflows, specifying the upgrade of the actions/checkout version, and follows a clear conventional commits style that matches the diff’s main content.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74522ff and ad18465.

📒 Files selected for processing (7)
  • .github/workflows/codeql.yml (1 hunks)
  • .github/workflows/commit-validation.yml (2 hunks)
  • .github/workflows/docsearch.yml (1 hunks)
  • .github/workflows/preview.yml (1 hunks)
  • .github/workflows/publish-package.yml (1 hunks)
  • .github/workflows/tests-linux.yml (11 hunks)
  • .github/workflows/tests-windows.yml (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: tests-linux (20) / postgres (17)
  • GitHub Check: tests-linux (20) / postgres (14)
  • GitHub Check: tests-linux (20) / oracle
  • GitHub Check: tests-linux (18) / oracle
  • GitHub Check: tests-linux (18) / postgres (17)
  • GitHub Check: tests-linux (20) / mysql_mariadb_latest
  • GitHub Check: tests-linux (18) / sap
  • GitHub Check: tests-linux (18) / postgres (14)
  • GitHub Check: tests-linux (20) / mssql
  • GitHub Check: tests-linux (20) / cockroachdb
  • GitHub Check: tests-linux (18) / mysql_mariadb
  • GitHub Check: tests-linux (20) / mongodb
  • GitHub Check: tests-linux (18) / sqlite
  • GitHub Check: tests-linux (18) / mongodb
  • GitHub Check: tests-windows / sqljs
  • GitHub Check: tests-linux (18) / mysql_mariadb_latest
  • GitHub Check: tests-linux (18) / sqljs
  • GitHub Check: tests-windows / better-sqlite3
  • GitHub Check: tests-linux (18) / better-sqlite3
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (7)
.github/workflows/codeql.yml (1)

26-26: Checkout v5 upgrade looks good

Nothing else in the job relies on old checkout defaults, so the bump to v5 is safe.

.github/workflows/docsearch.yml (1)

14-14: Docsearch workflow ready for checkout v5

The action upgrade is isolated and should function identically.

.github/workflows/preview.yml (1)

18-18: Preview workflow checkout bump validated

fetch-depth: 0 remains effective with actions/checkout@v5; no other adjustments needed.

.github/workflows/publish-package.yml (1)

14-14: Publish workflow compatible with checkout v5

The upgrade keeps the release pipeline intact.

.github/workflows/tests-windows.yml (1)

14-14: Windows test jobs aligned on checkout v5

All matrixed jobs share the same upgrade; runner compatibility looks good.

Also applies to: 37-37, 60-60

.github/workflows/commit-validation.yml (1)

21-35: Commit validation workflow upgrades verified

Moving both checkout and setup-node to v5 keeps the jobs consistent with the rest of the CI fleet.

.github/workflows/tests-linux.yml (1)

24-24: Linux matrix jobs now on checkout v5

All database-specific jobs share the same change; the upgrade is consistent and should be seamless.

Also applies to: 51-51, 81-81, 122-122, 163-163, 184-184, 205-205, 226-226, 266-266, 287-287, 314-314


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gioboa gioboa requested review from alumni and naorpeled October 3, 2025 09:51
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 3, 2025

typeorm-sql-js-example

npm i https://pkg.pr.new/typeorm/typeorm@11712

commit: ad18465

@coveralls
Copy link

Coverage Status

coverage: 76.433%. remained the same
when pulling ad18465 on gioboa:ci/actions-version
into 74522ff on typeorm:master.

@gioboa gioboa merged commit 2671579 into typeorm:master Oct 3, 2025
62 checks passed
@gioboa gioboa deleted the ci/actions-version branch October 3, 2025 11:12
ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
mgohin pushed a commit to mgohin/typeorm that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants