gulpfile.ts (1)

229-237: LGTM with minor suggestion for comment clarity.

The regex pattern correctly transforms ../../package.json to ../package.json, which is the correct relative path from build/package/commands/InitCommand.js to build/package/package.json in the published package structure.

Consider clarifying the comment to better describe the transformation:

-    /**
-     * Move reference to package.json one level up
-     */
+    /**
+     * Adjusts package.json import path for the packaged structure.
+     * Transforms "../../package.json" to "../package.json" in compiled InitCommand.
+     */

Additionally, verify that no other commands import package.json:

#!/bin/bash
# Check for other imports of package.json in commands directory
rg -n --type=ts 'from.*package\.json' src/commands/

src/commands/InitCommand.ts (3)

9-9: LGTM with recommendations for robustness.

The import correctly sources dependency versions from the local package.json, centralizing version management as intended.

Consider adding validation to ensure required properties exist, preventing silent failures if package.json structure changes:

 import ourPackageJson from "../../package.json"
+
+// Validate required package.json properties
+const requiredDevDeps = ["@types/node", "ts-node", "typescript", "mysql2", "pg", "sqlite3", "better-sqlite3", "oracledb", "mssql", "mongodb", "@google-cloud/spanner"];
+const requiredDeps = ["reflect-metadata"];
+const missingDevDeps = requiredDevDeps.filter(dep => !ourPackageJson.devDependencies?.[dep]);
+const missingDeps = requiredDeps.filter(dep => !ourPackageJson.dependencies?.[dep]);
+if (missingDevDeps.length > 0 || missingDeps.length > 0) {
+    throw new TypeORMError(
+        `Missing required dependencies in package.json: ${[...missingDevDeps, ...missingDeps].join(", ")}`
+    );
+}

---

685-687: Consider consistent property access notation.

The code mixes bracket notation (ourPackageJson.devDependencies["@types/node"]) and dot notation (ourPackageJson.devDependencies.typescript). While both are valid, bracket notation is safer for keys with special characters and provides consistency.

Apply this diff for consistency:

         packageJson.devDependencies = {
-            "@types/node": ourPackageJson.devDependencies["@types/node"],
-            "ts-node": ourPackageJson.devDependencies["ts-node"],
-            typescript: ourPackageJson.devDependencies.typescript,
+            "@types/node": ourPackageJson.devDependencies["@types/node"],
+            "ts-node": ourPackageJson.devDependencies["ts-node"],
+            typescript: ourPackageJson.devDependencies["typescript"],
             ...packageJson.devDependencies,
         }

---

701-732: LGTM with validation recommendation.

Database driver versions are correctly sourced from ourPackageJson.devDependencies, including the newly added @google-cloud/spanner.

To prevent silent failures if a driver dependency is missing from package.json, consider the validation suggested in the earlier comment on line 9.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro