Skip to content

ci: harmonize MongoDB version used in CI, local development environment and init command and bump to v8 #11704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gioboa merged 2 commits into from
Oct 5, 2025
Merged

ci: harmonize MongoDB version used in CI, local development environment and init command and bump to v8 #11704

gioboa merged 2 commits into from
Oct 5, 2025
+3 −3

Conversation

@pkuczynski
Copy link
Collaborator

@pkuczynski pkuczynski commented Oct 2, 2025 •
edited by coderabbitai bot
Loading

Description of change

MongoDB 5.0 reached its End of Life (EOL) on October 1, 2024.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • This pull request links relevant issues as Fixes #00000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change

Summary by CodeRabbit

  • Chores

    • Standardized the local development and generated Docker Compose environment to use MongoDB 8 for consistent behavior across setups.

  • Tests

    • Updated CI test workflow to run against MongoDB 8, aligning tests with the standardized environment and reducing environment-related discrepancies.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025 •
edited
Loading

Walkthrough

MongoDB image tags were standardized to mongo:8 across CI (.github/workflows/tests-linux.yml), docker-compose.yml, and the Docker Compose template in src/commands/InitCommand.ts. No other configuration, control flow, or public/exported-entity changes were made.

Changes

Cohort / File(s) Summary
CI workflow
.github/workflows/tests-linux.yml		 Updated MongoDB service image from mongo:5.0.31 to mongo:8.
Docker compose
docker-compose.yml		 Updated mongodb service image from mongo:5.0.31 to mongo:8.
Init template
src/commands/InitCommand.ts		 Updated Docker Compose template Mongo image from mongo:8.0.5 to mongo:8.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • OSA413
  • naorpeled
  • gioboa
  • sgarner

Poem

A rabbit nudges tags to eight,
Images shift and services wait.
CI hums soft, containers wake,
Compose files swap for compatibility's sake. 🥕
Hop—deploys feel light and great.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and succinctly describes the main change of harmonizing and bumping the MongoDB version to v8 across CI, local development, and the init command without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 547970a and ed69d14.

📒 Files selected for processing (2)
  • .github/workflows/tests-linux.yml (1 hunks)
  • src/commands/InitCommand.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/commands/InitCommand.ts
  • .github/workflows/tests-linux.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: tests-linux (20) / mysql_mariadb
  • GitHub Check: formatting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 2, 2025 •
edited
Loading

typeorm-sql-js-example

npm i https://pkg.pr.new/typeorm/typeorm@11704

commit: ed69d14

gioboa
gioboa approved these changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

naorpeled
naorpeled approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@naorpeled naorpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
maybe worth keeping both tests for now until v1 so we know we're not breaking existing usages in Mongo v5, but not sure it's crucial

@pkuczynski
Copy link
Collaborator Author

pkuczynski commented Oct 3, 2025

LGTM,
maybe worth keeping both tests for now until v1 so we know we're not breaking existing usages in Mongo v5, but not sure it's crucial

Which tests? I haven't changed any tests...

@naorpeled
Copy link
Member

naorpeled commented Oct 4, 2025

LGTM,
maybe worth keeping both tests for now until v1 so we know we're not breaking existing usages in Mongo v5, but not sure it's crucial

Which tests? I haven't changed any tests...

Both versions* sorry, not sure why I wrote tests lol

@coveralls
Copy link

coveralls commented Oct 5, 2025

Coverage Status

coverage: 76.433%. remained the same
when pulling ed69d14 on pkuczynski:mongo-8
into 2671579 on typeorm:master.

@gioboa gioboa merged commit 181154a into typeorm:master Oct 5, 2025
70 of 122 checks passed
@pkuczynski pkuczynski deleted the mongo-8 branch November 10, 2025 10:19
ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
@pkuczynski @ThbltLmr
ci: harmonize MongoDB version used in CI and local development enviro…
7ef3394 
…nment and bump to v8 (typeorm#11704)
mgohin pushed a commit to mgohin/typeorm that referenced this pull request Jan 15, 2026
@pkuczynski
ci: harmonize MongoDB version used in CI and local development enviro…
6db9b67 
…nment and bump to v8 (typeorm#11704)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naorpeled naorpeled naorpeled approved these changes

@gioboa gioboa gioboa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pkuczynski @naorpeled @coveralls @gioboa