Skip to content

refactor!: replace node-glob with tinyglobby, remove rimraf #11699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alumni merged 1 commit into from
Oct 1, 2025
Merged

refactor!: replace node-glob with tinyglobby, remove rimraf #11699

alumni merged 1 commit into from
Oct 1, 2025

Conversation

@alumni
Copy link
Collaborator

@alumni alumni commented Sep 30, 2025

Description of change

Replacing glob with tinygloby which has fewer dependencies and is smaller.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • This pull request links relevant issues as Fixes #00000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 30, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 30, 2025 •
edited
Loading

typeorm-sql-js-example

npm i https://pkg.pr.new/typeorm/typeorm@11699

commit: b9e4828

@alumni alumni force-pushed the refactor/use-tinyglobby branch 2 times, most recently from 9fb389a to 1eec465 Compare September 30, 2025 22:44
@alumni
refactor!: replace glob with tinyglobby, remove rimraf
b9e4828 
BREAKING CHANGE: glob patterns are now handled by tinyglobby instead of node-glob
@alumni alumni force-pushed the refactor/use-tinyglobby branch from 1eec465 to b9e4828 Compare September 30, 2025 22:47
@coveralls
Copy link

coveralls commented Sep 30, 2025

Coverage Status

coverage: 76.442% (+0.01%) from 76.431%
when pulling b9e4828 on alumni:refactor/use-tinyglobby
into 1894530 on typeorm:next.

gioboa
gioboa approved these changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks great 😃

@alumni alumni merged commit a7c387b into typeorm:next Oct 1, 2025
60 checks passed
@naorpeled naorpeled mentioned this pull request Oct 3, 2025
Open
4 tasks
@alumni alumni mentioned this pull request Dec 3, 2025
Open
26 tasks
@alumni alumni added this to the Next Major milestone Dec 3, 2025
alumni added a commit to alumni/typeorm that referenced this pull request Dec 12, 2025
@alumni
refactor!: replace glob with tinyglobby, remove rimraf (typeorm#11699)
f7c65a6
@Minishlink Minishlink mentioned this pull request Jan 12, 2026
Open
mgohin pushed a commit to mgohin/typeorm that referenced this pull request Jan 15, 2026
@alumni
refactor!: replace glob with tinyglobby, remove rimraf (typeorm#11699)
bff3266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gioboa gioboa gioboa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

TypeORM Roadmap
Status: Done

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alumni @coveralls @gioboa