-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore: update chai #11698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update chai #11698
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
| import { xfail } from "../../utils/xfail" | ||
|
|
||
| describe("github issues > #3387 named columns", () => { | ||
| describe("github issues > #3837 named columns", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I corrected the typo.
The test is for #3837
76e9bc0 to
c829c6a
Compare
gioboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
Description of change
Update
chai/sinonto their latest versions, now possible since we dropped support for old versions of Node.js.This should simplify the migration to e.g.
vitest.Pull-Request Checklist
nextbranchFixes #00000