Skip to content

Conversation

@alumni
Copy link
Collaborator

@alumni alumni commented Sep 30, 2025

Description of change

Update chai/sinon to their latest versions, now possible since we dropped support for old versions of Node.js.

This should simplify the migration to e.g. vitest.

Pull-Request Checklist

  • Code is up-to-date with the next branch
  • This pull request links relevant issues as Fixes #00000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 30, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 30, 2025

typeorm-sql-js-example

npm i https://pkg.pr.new/typeorm/typeorm@11698

commit: c829c6a

import { xfail } from "../../utils/xfail"

describe("github issues > #3387 named columns", () => {
describe("github issues > #3837 named columns", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I corrected the typo.

The test is for #3837

@alumni alumni marked this pull request as ready for review September 30, 2025 20:56
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@coveralls
Copy link

coveralls commented Sep 30, 2025

Coverage Status

coverage: 76.431%. remained the same
when pulling c829c6a on alumni:chore/update-chai
into b59c906 on typeorm:next.

@alumni alumni merged commit 1894530 into typeorm:next Sep 30, 2025
60 checks passed
alumni added a commit to alumni/typeorm that referenced this pull request Dec 11, 2025
mgohin pushed a commit to mgohin/typeorm that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants