Skip to content

docs: remove unused docs example file #11675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gioboa merged 2 commits into from
Oct 3, 2025
Merged

docs: remove unused docs example file #11675

gioboa merged 2 commits into from
Oct 3, 2025
+0 −7

Conversation

@pkuczynski
Copy link
Collaborator

@pkuczynski pkuczynski commented Sep 22, 2025 •
edited by coderabbitai bot
Loading

Description of change

I guess it was only an accidential leftover...

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • This pull request links relevant issues as Fixes #00000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change

Summary by CodeRabbit

  • Documentation
    • Removed a sample Markdown example page from the documentation site to streamline content and reduce clutter.
    • Users may notice that this example page is no longer accessible from navigation or direct links.
    • No application features, behavior, or public APIs were changed; this update affects documentation content only.
    • Any references to the removed page have been cleaned up to prevent dead links.

gioboa
gioboa approved these changes Sep 22, 2025
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👏 Thanks @pkuczynski

@gioboa gioboa requested a review from alumni September 22, 2025 09:53
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 29, 2025 •
edited
Loading

Walkthrough

A single documentation file, docs/src/pages/markdown-page.md, was removed. The deleted page contained a static Markdown example with front-matter and simple content. No runtime code, builds, or public APIs were modified.

Changes

Cohort / File(s) Summary of Changes
Docs page removal
docs/src/pages/markdown-page.md		 Deleted a static Markdown example page with front-matter and minimal content.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nibbled a page from the docs today,
A crumb of Markdown whisked away.
No code was stirred, no APIs shook—
Just lighter shelves in our knowledge nook.
Thump-thump! I hop with tidy cheer,
Cleaner burrow, crystal clear.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately describes the primary change by indicating the removal of an unused documentation example file, reflecting the core of the changeset without unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 925dee0 and a6f86d5.

📒 Files selected for processing (1)
  • docs/src/pages/markdown-page.md (0 hunks)
💤 Files with no reviewable changes (1)
  • docs/src/pages/markdown-page.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gioboa gioboa merged commit 336fef8 into typeorm:master Oct 3, 2025
1 check passed
ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
@pkuczynski @gioboa @ThbltLmr
docs: remove unused docs example file (typeorm#11675)
05aa572 
Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>
mgohin pushed a commit to mgohin/typeorm that referenced this pull request Jan 15, 2026
@pkuczynski @gioboa
docs: remove unused docs example file (typeorm#11675)
c455fd5 
Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naorpeled naorpeled naorpeled approved these changes

@gioboa gioboa gioboa approved these changes

@alumni alumni Awaiting requested review from alumni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkuczynski @naorpeled @gioboa