-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat(mysql): add support for vector columns on MariaDB and MySQL #11670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
9a76fd1 to
00719e7
Compare
00719e7 to
997b05e
Compare
997b05e to
0faefd9
Compare
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
gioboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏💪
OSA413
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about migrations? will changing a vector dimension be reflected in a new generated migration?
|
It should, it follows the same logic from string length ( The only adjustment I had to do was that the DB reported length in characters (bytes) is 4x the size of the vector, because each vector component takes 4 bytes (they are 32bit floating point numbers). This is covered by the tests in the PR already. |
Description of change
Add support for vector columns in MySQL and MariaDB
Pull-Request Checklist
masterbranchFixes #00000